Summary: | [WinCairo][TestWebKitAPI] Implement PlatformWebView for TestWebKit | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||
Component: | Tools / Tests | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, bfulgham, lforschler, pvollan, rniwa, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 174003 | ||||||||
Attachments: |
|
Description
Fujii Hironori
2018-04-11 19:14:09 PDT
Created attachment 337769 [details]
Patch
Could anyone review? Comment on attachment 337769 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337769&action=review > Tools/TestWebKitAPI/win/PlatformUtilitiesWin.cpp:38 > + constexpr size_t bufferLength = _MAX_PATH * 4; This seems excessive. > Tools/TestWebKitAPI/win/PlatformUtilitiesWin.cpp:53 > + String filename = String::format("..\\..\\..\\Tools\\TestWebKitAPI\\Tests\\WebKit\\%s.%s", resource, extension); This seems specific to a certain build configuration. Comment on attachment 337769 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337769&action=review Thank you for the review. >> Tools/TestWebKitAPI/win/PlatformUtilitiesWin.cpp:38 >> + constexpr size_t bufferLength = _MAX_PATH * 4; > > This seems excessive. Agreed. I'll use _MAX_PATH+1. >> Tools/TestWebKitAPI/win/PlatformUtilitiesWin.cpp:53 >> + String filename = String::format("..\\..\\..\\Tools\\TestWebKitAPI\\Tests\\WebKit\\%s.%s", resource, extension); > > This seems specific to a certain build configuration. Mac port is copying the resource file into the build directory. GTK and WPE ports are using a env var to specify the source directory. Old WebKit port was using the same approach with Mac port. I'm going to solve this problem in another bug. Created attachment 338077 [details]
Patch to land
Committed r230744: <https://trac.webkit.org/changeset/230744> (In reply to Fujii Hironori from comment #4) > I'm going to solve this problem in another bug. Filed Bug 184722. |