Bug 184524 – [WinCairo][TestWebKitAPI] Implement PlatformWebView for TestWebKit

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Fujii Hironori]

[WinCairo][TestWebKitAPI] Implement PlatformWebView for TestWebKit

It was removed in Bug 104607.

[Fujii Hironori]

Created attachment 337769 [details]
Patch

[Fujii Hironori]

Could anyone review?

[Alex Christensen]

Comment on attachment 337769 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337769&action=review

> Tools/TestWebKitAPI/win/PlatformUtilitiesWin.cpp:38
> +    constexpr size_t bufferLength = _MAX_PATH * 4;

This seems excessive.

> Tools/TestWebKitAPI/win/PlatformUtilitiesWin.cpp:53
> +    String filename = String::format("..\\..\\..\\Tools\\TestWebKitAPI\\Tests\\WebKit\\%s.%s", resource, extension);

This seems specific to a certain build configuration.

[Fujii Hironori]

Comment on attachment 337769 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337769&action=review

Thank you for the review.

>> Tools/TestWebKitAPI/win/PlatformUtilitiesWin.cpp:38
>> +    constexpr size_t bufferLength = _MAX_PATH * 4;
> 
> This seems excessive.

Agreed. I'll use _MAX_PATH+1.

>> Tools/TestWebKitAPI/win/PlatformUtilitiesWin.cpp:53
>> +    String filename = String::format("..\\..\\..\\Tools\\TestWebKitAPI\\Tests\\WebKit\\%s.%s", resource, extension);
> 
> This seems specific to a certain build configuration.

Mac port is copying the resource file into the build directory.
GTK and WPE ports are using a env var to specify the source directory.
Old WebKit port was using the same approach with Mac port.
I'm going to solve this problem in another bug.

[Fujii Hironori]

Created attachment 338077 [details]
Patch to land

[Fujii Hironori]

Committed r230744: <https://trac.webkit.org/changeset/230744>

[Radar WebKit Bug Importer]

<rdar://problem/39512612>

[Fujii Hironori]

(In reply to Fujii Hironori from comment #4)
> I'm going to solve this problem in another bug.

Filed Bug 184722.