Bug 184508

Summary: Fix TestInvocation class for newer versions of clang
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, lforschler
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2018-04-11 10:22:42 PDT
Newer versions of clang raise a warning when compiling the TestInvocation class because it is not declared as final and does not have a virtual destructor.
Attachments
Patch (1.18 KB, patch)
2018-04-11 10:24 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.22 KB, patch)
2018-04-11 13:19 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2018-04-11 10:24:33 PDT
Created attachment 337710 [details] Patch
Alexey Proskuryakov
Comment 2 2018-04-11 12:54:01 PDT
rdar://problem/39328648
Jonathan Bedard
Comment 3 2018-04-11 13:19:30 PDT
Created attachment 337727 [details] Patch for landing
WebKit Commit Bot
Comment 4 2018-04-11 13:38:28 PDT
Comment on attachment 337727 [details] Patch for landing Clearing flags on attachment: 337727 Committed r230545: <https://trac.webkit.org/changeset/230545>
WebKit Commit Bot
Comment 5 2018-04-11 13:38:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.