Bug 184507

Summary: pemfile.py should not assume POSIX line endings
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: Tools / TestsAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, ews-watchlist, glenn, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

Ross Kirsling
Reported 2018-04-11 09:59:42 PDT
pemfile.py should not assume POSIX line endings
Attachments
Patch (1.89 KB, patch)
2018-04-11 10:00 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch (1.22 KB, patch)
2018-04-11 10:16 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch (2.15 KB, patch)
2018-04-11 10:40 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.60 KB, patch)
2018-04-12 13:07 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.39 KB, patch)
2018-04-12 13:09 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2018-04-11 10:00:56 PDT
Created attachment 337708 [details] Patch
Ross Kirsling
Comment 2 2018-04-11 10:16:23 PDT
Created attachment 337709 [details] Patch
Daniel Bates
Comment 3 2018-04-11 10:22:23 PDT
Comment on attachment 337709 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337709&action=review > Tools/Scripts/webkitpy/common/system/pemfile.py:101 > + lines = re.split("\r?\n", content) Please add a unit test for this change.
Ross Kirsling
Comment 4 2018-04-11 10:40:54 PDT
Created attachment 337712 [details] Patch
Daniel Bates
Comment 5 2018-04-12 11:27:47 PDT
Comment on attachment 337712 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337712&action=review r=me > Tools/Scripts/webkitpy/common/system/pemfile.py:101 > + lines = re.split('\r?\n', content) Could the PEM file ever contain only carriage returns (\r)?
Ross Kirsling
Comment 6 2018-04-12 13:07:38 PDT
Created attachment 337826 [details] Patch for landing
Ross Kirsling
Comment 7 2018-04-12 13:09:14 PDT
Created attachment 337827 [details] Patch for landing
WebKit Commit Bot
Comment 8 2018-04-12 13:48:15 PDT
Comment on attachment 337827 [details] Patch for landing Clearing flags on attachment: 337827 Committed r230593: <https://trac.webkit.org/changeset/230593>
WebKit Commit Bot
Comment 9 2018-04-12 13:48:16 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2018-04-12 13:49:19 PDT
<rdar://problem/39392571>
Note You need to log in before you can comment on or make changes to this bug.