Bug 184470

Summary: Remove block selection code
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bdakin, commit-queue, ryanhaddad, timothy, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch timothy: review+, timothy: commit-queue-

Description Megan Gardner 2018-04-10 14:30:40 PDT
Remove block selection code
Comment 1 Megan Gardner 2018-04-10 14:32:25 PDT
Created attachment 337636 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2018-04-10 14:34:54 PDT
<rdar://problem/39327273>
Comment 3 WebKit Commit Bot 2018-04-10 18:26:35 PDT
Comment on attachment 337636 [details]
Patch

Clearing flags on attachment: 337636

Committed r230508: <https://trac.webkit.org/changeset/230508>
Comment 4 WebKit Commit Bot 2018-04-10 18:26:37 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Ryan Haddad 2018-04-11 09:01:36 PDT
Reverted r230508 for reason:

Breaks internal builds.

Committed r230526: <https://trac.webkit.org/changeset/230526>
Comment 6 Megan Gardner 2018-04-12 12:08:16 PDT
Created attachment 337819 [details]
Patch
Comment 7 Timothy Hatcher 2018-04-12 12:29:44 PDT
Comment on attachment 337819 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337819&action=review

> Source/WebKit/ChangeLog:-444
> -2018-04-10  Megan Gardner  <megan_gardner@apple.com>

You should just leave the old entries.

> Source/WebKit/ChangeLog:644
> +2018-04-10  Megan Gardner  <megan_gardner@apple.com>

Why is this being added here?
Comment 8 Megan Gardner 2018-04-12 12:57:55 PDT
https://trac.webkit.org/r230591