WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
184470
Remove block selection code
https://bugs.webkit.org/show_bug.cgi?id=184470
Summary
Remove block selection code
Megan Gardner
Reported
2018-04-10 14:30:40 PDT
Remove block selection code
Attachments
Patch
(37.19 KB, patch)
2018-04-10 14:32 PDT
,
Megan Gardner
no flags
Details
Formatted Diff
Diff
Patch
(41.63 KB, patch)
2018-04-12 12:08 PDT
,
Megan Gardner
timothy
: review+
timothy
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Megan Gardner
Comment 1
2018-04-10 14:32:25 PDT
Created
attachment 337636
[details]
Patch
Radar WebKit Bug Importer
Comment 2
2018-04-10 14:34:54 PDT
<
rdar://problem/39327273
>
WebKit Commit Bot
Comment 3
2018-04-10 18:26:35 PDT
Comment on
attachment 337636
[details]
Patch Clearing flags on attachment: 337636 Committed
r230508
: <
https://trac.webkit.org/changeset/230508
>
WebKit Commit Bot
Comment 4
2018-04-10 18:26:37 PDT
All reviewed patches have been landed. Closing bug.
Ryan Haddad
Comment 5
2018-04-11 09:01:36 PDT
Reverted
r230508
for reason: Breaks internal builds. Committed
r230526
: <
https://trac.webkit.org/changeset/230526
>
Megan Gardner
Comment 6
2018-04-12 12:08:16 PDT
Created
attachment 337819
[details]
Patch
Timothy Hatcher
Comment 7
2018-04-12 12:29:44 PDT
Comment on
attachment 337819
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=337819&action=review
> Source/WebKit/ChangeLog:-444 > -2018-04-10 Megan Gardner <
megan_gardner@apple.com
>
You should just leave the old entries.
> Source/WebKit/ChangeLog:644 > +2018-04-10 Megan Gardner <
megan_gardner@apple.com
>
Why is this being added here?
Megan Gardner
Comment 8
2018-04-12 12:57:55 PDT
https://trac.webkit.org/r230591
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug