Bug 184470 - Remove block selection code
Summary: Remove block selection code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-10 14:30 PDT by Megan Gardner
Modified: 2018-04-12 12:57 PDT (History)
7 users (show)

See Also:

Attachments
Patch (37.19 KB, patch)
2018-04-10 14:32 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch (41.63 KB, patch)
2018-04-12 12:08 PDT, Megan Gardner 		timothy: review+
timothy: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2018-04-10 14:30:40 PDT 
Remove block selection code
Comment 1 Megan Gardner 2018-04-10 14:32:25 PDT 
Created attachment 337636 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2018-04-10 14:34:54 PDT 
<rdar://problem/39327273>
Comment 3 WebKit Commit Bot 2018-04-10 18:26:35 PDT 
Comment on attachment 337636 [details]
Patch

Clearing flags on attachment: 337636

Committed r230508: <https://trac.webkit.org/changeset/230508>
Comment 4 WebKit Commit Bot 2018-04-10 18:26:37 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Ryan Haddad 2018-04-11 09:01:36 PDT 
Reverted r230508 for reason:

Breaks internal builds.

Committed r230526: <https://trac.webkit.org/changeset/230526>
Comment 6 Megan Gardner 2018-04-12 12:08:16 PDT 
Created attachment 337819 [details]
Patch
Comment 7 Timothy Hatcher 2018-04-12 12:29:44 PDT 
Comment on attachment 337819 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337819&action=review

> Source/WebKit/ChangeLog:-444
> -2018-04-10  Megan Gardner  <megan_gardner@apple.com>

You should just leave the old entries.

> Source/WebKit/ChangeLog:644
> +2018-04-10  Megan Gardner  <megan_gardner@apple.com>

Why is this being added here?
Comment 8 Megan Gardner 2018-04-12 12:57:55 PDT 
https://trac.webkit.org/r230591