Bug 18447

Summary:

Setting of CSSStyleDeclaration.prototype.foo on outer window affects prototype of inner window

Product:

WebKit

Reporter:

Ojan Vafai <ovafai>

Component:

WebCore JavaScript

Assignee:

James Kozianski <koz>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ap, commit-queue, ian.eng.webkit, noel.gordon, ojan, sam

Priority:

Version:

525.x (Safari 3.1)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Shows that CSSStyleDeclaration and String behave differently.	none
Patch	none
Patch	none

Ojan Vafai

Reported 2008-04-12 15:54:02 PDT

That summary isn't the most clear. Will attach a test case. In short, if I set a prototype property in an outer window and then grab an object from that type from a frame, that property shouldn't be set on the object from the frame. This is how Firefox and Opera work.

Attachments
Shows that CSSStyleDeclaration and String behave differently. (507 bytes, text/html) 2008-04-12 15:54 PDT, Ojan Vafai	no flags	Details
Patch (1.96 KB, patch) 2010-09-13 16:46 PDT, James Kozianski	no flags	Details Formatted Diff Diff
Patch (2.20 KB, patch) 2010-09-13 18:28 PDT, James Kozianski	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Ojan Vafai

Comment 1 2008-04-12 15:54:57 PDT

Created attachment 20495 [details] Shows that CSSStyleDeclaration and String behave differently.

Alexey Proskuryakov

Comment 2 2010-09-08 15:45:05 PDT

This no longer occurs in Safari 5.0.1. Not sure if we need to land a test for this.

Ojan Vafai

Comment 3 2010-09-09 20:24:53 PDT

Ugh, didn't mean to close the bug. Probably worth committing a test for this.

James Kozianski

Comment 4 2010-09-13 16:46:53 PDT

Created attachment 67488 [details] Patch

Adam Barth

Comment 5 2010-09-13 16:48:36 PDT

Comment on attachment 67488 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=67488&action=prettypatch > LayoutTests/fast/frames/frame-prototype-inheritance.html:11 > + // alert(win.CSSStyleDeclaration.prototype.foo); Please remove commented out code.

James Kozianski

Comment 6 2010-09-13 18:28:04 PDT

Created attachment 67502 [details] Patch

Ojan Vafai

Comment 7 2010-09-13 18:33:01 PDT

Comment on attachment 67502 [details] Patch Did you mean to set cq?

WebKit Commit Bot

Comment 8 2010-09-14 14:42:02 PDT

Comment on attachment 67502 [details] Patch Rejecting patch 67502 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing,media', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20991 test cases. fast/css/visited-link-hang.html -> failed Exiting early after 1 failures. 6198 tests run. 131.28s total testing time 6197 test cases (99%) succeeded 1 test case (<1%) had incorrect layout Full output: http://queues.webkit.org/results/4059011

Adam Barth

Comment 9 2010-09-14 14:53:32 PDT

> Rejecting patch 67502 from commit-queue. We just change some core logic in the commit-queue. Not sure if we have a bug now.

WebKit Commit Bot

Comment 10 2010-09-14 16:15:52 PDT

Comment on attachment 67502 [details] Patch Clearing flags on attachment: 67502 Committed r67511: <http://trac.webkit.org/changeset/67511>

WebKit Commit Bot

Comment 11 2010-09-14 16:15:58 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.