Bug 184453
| Summary: | REGRESSION (r230445): Layout Test imported/w3c/web-platform-tests/workers/name-property.html is a flaky failure | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | brendan, youennf, zcorpan |
| Priority: | P2 | ||
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=259409 | ||
Ryan Haddad
The following layout test is flaky on all ports.
imported/w3c/web-platform-tests/workers/name-property.html
Probable cause:
This started with the WPT re-sync in https://trac.webkit.org/changeset/230445/webkit
Flakiness Dashboard:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fworkers%2Fname-property.html
--- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/workers/name-property-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/workers/name-property-actual.txt
@@ -1,7 +1,7 @@
CONSOLE MESSAGE: line 20: ReferenceError: Can't find variable: SharedWorker
FAIL Test the name property of shared and dedicated workers via the name constructor option ReferenceError: Can't find variable: SharedWorker
+FAIL name property value for DedicatedWorkerGlobalScope assert_true: property exists on the global expected true got false
PASS Declaring name as an accidental global must not cause a harness error for DedicatedWorkerGlobalScope
-FAIL name property value for DedicatedWorkerGlobalScope assert_true: property exists on the global expected true got false
PASS name property is replaceable for DedicatedWorkerGlobalScope
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ryan Haddad
Marked test as flaky in https://trac.webkit.org/r230483
Simon Pieters (:zcorpan)
The test was fixed in https://github.com/web-platform-tests/wpt/pull/11186
Can TestExpectations be updated?
Ryan Haddad
(In reply to Simon Pieters from comment #2)
> The test was fixed in https://github.com/web-platform-tests/wpt/pull/11186
>
> Can TestExpectations be updated?
I don't think anyone has merged the fix into our repo, as the test is still frequently failing according to https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fworkers%2Fname-property.html
Simon Pieters (:zcorpan)
Has the test been imported now? Can it be imported and enabled?
It would be *nice* with automatic two-way sync for wpt<->WebKit. :-)
Sam Sneddon [:gsnedders]
The flakiness may actually be down to bug 259409.