Summary: | [Win] Add UserAgentWin.cpp | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||
Component: | WebCore Misc. | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | mcatanzaro, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 174003 | ||||||||
Attachments: |
|
Description
Fujii Hironori
2018-04-09 21:45:04 PDT
Created attachment 337586 [details]
Patch
Comment on attachment 337586 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337586&action=review > Source/WebCore/ChangeLog:8 > + No new tests (No behavior change). It's definitely a behavior change, right? You have a user agent now where you did not before. > Source/WebCore/platform/win/UserAgentWin.cpp:55 > + return String(); return { } Comment on attachment 337586 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337586&action=review Thank you for the review. >> Source/WebCore/ChangeLog:8 >> + No new tests (No behavior change). > > It's definitely a behavior change, right? You have a user agent now where you did not before. WebPageProxyWin.cpp is not upstreamed yet. This patch changes nothing at the moment. In the futre, WebKit2 for Windows port and WebKitTestRunner for Windows port will be finished to implement. Existing test case http/tests/navigation/useragent.php will covers this change. Created attachment 337666 [details]
Patch to land
Committed r230509: <https://trac.webkit.org/changeset/230509> |