Bug 184435

Summary: [Extra zoom mode] Add a mechanism to zoom to fixed scales when double tapping in extra zoom mode
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit Misc.Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bdakin, commit-queue, dino, thorton, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Fix WPE builds
dino: review+
Patch for landing none

Wenson Hsieh
Reported 2018-04-09 19:09:18 PDT
<rdar://problem/38726260>
Attachments
Patch (25.60 KB, patch)
2018-04-09 20:46 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Fix WPE builds (25.52 KB, patch)
2018-04-09 20:51 PDT, Wenson Hsieh 		dino: review+
DetailsFormatted DiffDiff
Patch for landing (25.47 KB, patch)
2018-04-10 17:24 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2018-04-09 20:46:10 PDT
Created attachment 337581 [details] Patch
Wenson Hsieh
Comment 2 2018-04-09 20:51:28 PDT
Created attachment 337582 [details] Fix WPE builds
Dean Jackson
Comment 3 2018-04-10 14:47:47 PDT
Comment on attachment 337582 [details] Fix WPE builds View in context: https://bugs.webkit.org/attachment.cgi?id=337582&action=review > Source/WebKit/WebProcess/WebPage/ViewGestureGeometryCollector.cpp:141 > + return { }; Should this be nullopt?
Wenson Hsieh
Comment 4 2018-04-10 15:10:50 PDT
Comment on attachment 337582 [details] Fix WPE builds View in context: https://bugs.webkit.org/attachment.cgi?id=337582&action=review >> Source/WebKit/WebProcess/WebPage/ViewGestureGeometryCollector.cpp:141 >> + return { }; > > Should this be nullopt? Sure! Changed to std::nullopt.
Wenson Hsieh
Comment 5 2018-04-10 17:24:29 PDT
Created attachment 337659 [details] Patch for landing
WebKit Commit Bot
Comment 6 2018-04-10 18:02:59 PDT
Comment on attachment 337659 [details] Patch for landing Clearing flags on attachment: 337659 Committed r230506: <https://trac.webkit.org/changeset/230506>
Note You need to log in before you can comment on or make changes to this bug.