Bug 184431

Summary: Add Justin Fan to list of WebKit contributors
Product: WebKit Reporter: Justin Fan <justin_fan>
Component: Tools / TestsAssignee: Justin Fan <justin_fan>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-feeder, ews-watchlist, glenn, justin_fan, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ews-feeder: commit-queue-

Justin Fan
Reported 2018-04-09 16:03:09 PDT
hello world?
Attachments
Patch (1.21 KB, patch)
2018-08-27 12:36 PDT, Justin Fan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-04-09 16:04:07 PDT
<rdar://problem/39297019>
Justin Fan
Comment 2 2018-08-27 12:36:12 PDT
Created attachment 348186 [details] Patch
EWS
Comment 3 2018-08-27 12:37:58 PDT
Comment on attachment 348186 [details] Patch Rejecting attachment 348186 [details] from commit-queue. justin_fan@apple.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
EWS Watchlist
Comment 4 2018-08-27 12:39:41 PDT
Attachment 348186 [details] did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0: contributors.json should not be modified through the commit queue [json/syntax] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Justin Fan
Comment 5 2018-08-27 14:38:23 PDT
Manually committed r235402: <https://trac.webkit.org/changeset/235402>
Note You need to log in before you can comment on or make changes to this bug.