Bug 184431 - Add Justin Fan to list of WebKit contributors
Summary: Add Justin Fan to list of WebKit contributors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Justin Fan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-09 16:03 PDT by Justin Fan
Modified: 2018-08-27 14:39 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.21 KB, patch)
2018-08-27 12:36 PDT, Justin Fan
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Fan 2018-04-09 16:03:09 PDT
hello world?
Comment 1 Radar WebKit Bug Importer 2018-04-09 16:04:07 PDT
<rdar://problem/39297019>
Comment 2 Justin Fan 2018-08-27 12:36:12 PDT
Created attachment 348186 [details]
Patch
Comment 3 EWS 2018-08-27 12:37:58 PDT
Comment on attachment 348186 [details]
Patch

Rejecting attachment 348186 [details] from commit-queue.

justin_fan@apple.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 4 EWS Watchlist 2018-08-27 12:39:41 PDT
Attachment 348186 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0:  contributors.json should not be modified through the commit queue  [json/syntax] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Justin Fan 2018-08-27 14:38:23 PDT
Manually committed r235402: <https://trac.webkit.org/changeset/235402>