Bug 184427

Summary: webrtc/datachannel/bufferedAmountLowThreshold tests are failing on WK1
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, eric.carlson, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description youenn fablet 2018-04-09 13:40:46 PDT
webrtc/datachannel/bufferedAmountLowThreshold tests are failing on WK1
Comment 1 youenn fablet 2018-04-09 13:43:10 PDT
Created attachment 337537 [details]
Patch
Comment 2 Eric Carlson 2018-04-09 14:02:59 PDT
Comment on attachment 337537 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337537&action=review

> LayoutTests/webrtc/datachannel/bufferedAmountLowThreshold-default.html:26
> -for (var cptr = 0; cptr < 14; ++cptr)
> +for (var cptr = 0; cptr < 10; ++cptr)

A comment in the ChangeLog about why this fixes the test could be helpful to someone looking at this in the future.
Comment 3 youenn fablet 2018-04-09 15:15:15 PDT
Created attachment 337551 [details]
Patch
Comment 4 WebKit Commit Bot 2018-04-10 14:14:01 PDT
Comment on attachment 337551 [details]
Patch

Clearing flags on attachment: 337551

Committed r230493: <https://trac.webkit.org/changeset/230493>
Comment 5 WebKit Commit Bot 2018-04-10 14:14:02 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-04-10 14:15:32 PDT
<rdar://problem/39326506>