Bug 184423

Summary: Fix the selection assistant selectionView build
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, megan_gardner, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Jer Noble 2018-04-09 11:55:08 PDT
Fix the selection assistant selectionView build
Comment 1 Radar WebKit Bug Importer 2018-04-09 11:55:56 PDT
<rdar://problem/39288235>
Comment 2 Jer Noble 2018-04-09 11:58:11 PDT
Created attachment 337516 [details]
Patch
Comment 3 Wenson Hsieh 2018-04-09 12:07:37 PDT
Comment on attachment 337516 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337516&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4498
>          [[_webSelectionAssistant selectionView] setHidden:NO];

You might want to consider guarding the declaration of the selectionView property in UIKitSPI.h with ENABLE(MINIMAL_SIMULATOR) as well.
Comment 4 Jer Noble 2018-04-09 12:10:27 PDT
(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 337516 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=337516&action=review
> 
> > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4498
> >          [[_webSelectionAssistant selectionView] setHidden:NO];
> 
> You might want to consider guarding the declaration of the selectionView
> property in UIKitSPI.h with ENABLE(MINIMAL_SIMULATOR) as well.

Will do.
Comment 5 Jer Noble 2018-04-09 12:18:28 PDT
Created attachment 337522 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2018-04-09 12:58:22 PDT
Comment on attachment 337522 [details]
Patch for landing

Clearing flags on attachment: 337522

Committed r230448: <https://trac.webkit.org/changeset/230448>
Comment 7 WebKit Commit Bot 2018-04-09 12:58:23 PDT
All reviewed patches have been landed.  Closing bug.