Bug 184415

Summary:

Change Event's returnValue so it doesn't expose a new primitive

Product:

WebKit

Reporter:

Anne van Kesteren <annevk>

Component:

DOM

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alecflett, beidson, cdumez, commit-queue, darin, dbates, esprehn+autocc, ews-watchlist, jsbell, kangil.han, rniwa, sam, webkit-bug-importer, webkit

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

URL:

https://dom.spec.whatwg.org/#dom-event-returnvalue

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews200 for win-future	none
Patch	none

Anne van Kesteren

Reported 2018-04-09 04:34:33 PDT

See https://github.com/whatwg/dom/pull/626 and https://github.com/w3c/web-platform-tests/pull/10258.

Attachments
Patch (45.78 KB, patch) 2018-04-13 14:16 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (46.92 KB, patch) 2018-04-13 15:00 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews200 for win-future (12.67 MB, application/zip) 2018-04-13 16:55 PDT, EWS Watchlist	no flags	Details
Patch (45.63 KB, patch) 2018-04-15 17:17 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2018-04-13 14:16:02 PDT

Created attachment 337923 [details] Patch

Chris Dumez

Comment 2 2018-04-13 15:00:11 PDT

Created attachment 337925 [details] Patch

EWS Watchlist

Comment 3 2018-04-13 16:55:35 PDT

Comment on attachment 337925 [details] Patch Attachment 337925 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7310054 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html

EWS Watchlist

Comment 4 2018-04-13 16:55:46 PDT

Created attachment 337932 [details] Archive of layout-test-results from ews200 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Chris Dumez

Comment 5 2018-04-13 16:59:54 PDT

Comment on attachment 337925 [details] Patch Windows failure looks unrelated.

Darin Adler

Comment 6 2018-04-15 12:01:33 PDT

Comment on attachment 337925 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337925&action=review > Source/WebCore/dom/Event.h:99 > + WEBCORE_EXPORT void setLegacyReturnValue(bool); Why less inlining? I would have left everything in the header and marked inline.

Chris Dumez

Comment 7 2018-04-15 17:17:25 PDT

Created attachment 337985 [details] Patch

WebKit Commit Bot

Comment 8 2018-04-15 18:01:24 PDT

Comment on attachment 337985 [details] Patch Clearing flags on attachment: 337985 Committed r230664: <https://trac.webkit.org/changeset/230664>

WebKit Commit Bot

Comment 9 2018-04-15 18:01:26 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 10 2018-04-15 18:03:26 PDT

<rdar://problem/39445537>

Note You need to log in before you can comment on or make changes to this bug.