Bug 184407

Summary: [GTK] check target looks broken
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, commit-queue, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2018-04-08 20:19:12 PDT
I see in Source/PlatformGTK.cmake: add_custom_target(check COMMAND ${TOOLS_DIR}/Scripts/run-gtk-tests COMMAND ${TOOLS_DIR}/gtk/check-for-webkitdom-api-breaks ) But we got rid of check-for-webkitdom-api-breaks a long time ago, when we stopped autogenerating the DOM API. So that probably does not work.
Attachments
Patch (1.49 KB, patch)
2018-04-09 09:24 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2018-04-09 09:24:00 PDT
Created attachment 337500 [details] Patch
WebKit Commit Bot
Comment 2 2018-04-23 18:08:02 PDT
Comment on attachment 337500 [details] Patch Clearing flags on attachment: 337500 Committed r230937: <https://trac.webkit.org/changeset/230937>
WebKit Commit Bot
Comment 3 2018-04-23 18:08:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.