Bug 184402

Summary: [iOS] WKContentView and WKLegacyPDFView should share application state tracking logic
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, eric.carlson, mitz, thorton, webkit-bug-importer, wenson_hsieh, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch aestes: commit-queue-

Andy Estes
Reported 2018-04-08 13:54:17 PDT
[iOS] WKContentView and WKLegacyPDFView should share application state tracking logic
Attachments
Patch (22.64 KB, patch)
2018-04-08 14:00 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (22.65 KB, patch)
2018-04-08 17:53 PDT, Andy Estes 		aestes: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2018-04-08 14:00:59 PDT
Created attachment 337464 [details] Patch
mitz
Comment 2 2018-04-08 15:26:03 PDT
Comment on attachment 337464 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337464&action=review > Source/WebKit/UIProcess/ios/WKApplicationStateTrackingView.mm:38 > +using namespace WebCore; > +using namespace WebKit; I thought we were moving away from doing this in modern WebKit.
Andy Estes
Comment 3 2018-04-08 16:01:47 PDT
(In reply to mitz from comment #2) > Comment on attachment 337464 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=337464&action=review > > > Source/WebKit/UIProcess/ios/WKApplicationStateTrackingView.mm:38 > > +using namespace WebCore; > > +using namespace WebKit; > > I thought we were moving away from doing this in modern WebKit. Oh, ok. Maybe it makes unifying sources more difficult? I'll get rid of them. Thanks for reviewing!
Andy Estes
Comment 4 2018-04-08 17:53:14 PDT
Created attachment 337471 [details] Patch
Andy Estes
Comment 5 2018-04-08 18:48:36 PDT
Committed r230383: <https://trac.webkit.org/changeset/230383>
Radar WebKit Bug Importer
Comment 6 2018-04-08 18:49:20 PDT
<rdar://problem/39269308>
Note You need to log in before you can comment on or make changes to this bug.