Bug 184401

Summary: [WebCore] Use @getByIdDirectPrivate / @putByIdDirectPrivate in WebCore JS
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: WebCore JavaScriptAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, rniwa, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 183970    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews100 for mac-sierra
none
Archive of layout-test-results from ews104 for mac-sierra-wk2
none
Patch
none
Patch none

Yusuke Suzuki
Reported 2018-04-08 10:13:13 PDT
...
Attachments
Patch (89.47 KB, patch)
2018-04-13 08:09 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews100 for mac-sierra (339.53 KB, application/zip)
2018-04-13 08:59 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (234.96 KB, application/zip)
2018-04-13 09:01 PDT, EWS Watchlist 		no flags
Details
Patch (89.47 KB, patch)
2018-04-13 09:02 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (89.47 KB, patch)
2018-04-13 09:08 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-04-13 08:09:45 PDT
Created attachment 337888 [details] Patch
Saam Barati
Comment 2 2018-04-13 08:27:45 PDT
Comment on attachment 337888 [details] Patch rs=me
EWS Watchlist
Comment 3 2018-04-13 08:59:21 PDT
Comment on attachment 337888 [details] Patch Attachment 337888 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7305523 Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 4 2018-04-13 08:59:22 PDT
Created attachment 337889 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 5 2018-04-13 09:01:09 PDT
Comment on attachment 337888 [details] Patch Attachment 337888 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7305516 Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 6 2018-04-13 09:01:10 PDT
Created attachment 337890 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Yusuke Suzuki
Comment 7 2018-04-13 09:02:40 PDT
Created attachment 337891 [details] Patch
Yusuke Suzuki
Comment 8 2018-04-13 09:03:30 PDT
Comment on attachment 337891 [details] Patch Oops, r+ is cleared. This is patch for landing (after EWS becomes green).
Yusuke Suzuki
Comment 9 2018-04-13 09:08:07 PDT
Created attachment 337892 [details] Patch Patch for landing
Yusuke Suzuki
Comment 10 2018-04-13 10:01:46 PDT
Committed r230637: <https://trac.webkit.org/changeset/230637>
Radar WebKit Bug Importer
Comment 11 2018-04-13 10:03:34 PDT
<rdar://problem/39415033>
Note You need to log in before you can comment on or make changes to this bug.