Bug 184401 - [WebCore] Use @getByIdDirectPrivate / @putByIdDirectPrivate in WebCore JS
Summary: [WebCore] Use @getByIdDirectPrivate / @putByIdDirectPrivate in WebCore JS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on: 183970
Blocks:
  Show dependency treegraph
 
Reported: 2018-04-08 10:13 PDT by Yusuke Suzuki
Modified: 2018-04-13 10:03 PDT (History)
4 users (show)

See Also:


Attachments
Patch (89.47 KB, patch)
2018-04-13 08:09 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-sierra (339.53 KB, application/zip)
2018-04-13 08:59 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (234.96 KB, application/zip)
2018-04-13 09:01 PDT, Build Bot
no flags Details
Patch (89.47 KB, patch)
2018-04-13 09:02 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (89.47 KB, patch)
2018-04-13 09:08 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-04-08 10:13:13 PDT
...
Comment 1 Yusuke Suzuki 2018-04-13 08:09:45 PDT
Created attachment 337888 [details]
Patch
Comment 2 Saam Barati 2018-04-13 08:27:45 PDT
Comment on attachment 337888 [details]
Patch

rs=me
Comment 3 Build Bot 2018-04-13 08:59:21 PDT
Comment on attachment 337888 [details]
Patch

Attachment 337888 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7305523

Number of test failures exceeded the failure limit.
Comment 4 Build Bot 2018-04-13 08:59:22 PDT
Created attachment 337889 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 5 Build Bot 2018-04-13 09:01:09 PDT
Comment on attachment 337888 [details]
Patch

Attachment 337888 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7305516

Number of test failures exceeded the failure limit.
Comment 6 Build Bot 2018-04-13 09:01:10 PDT
Created attachment 337890 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 7 Yusuke Suzuki 2018-04-13 09:02:40 PDT
Created attachment 337891 [details]
Patch
Comment 8 Yusuke Suzuki 2018-04-13 09:03:30 PDT
Comment on attachment 337891 [details]
Patch

Oops, r+ is cleared. This is patch for landing (after EWS becomes green).
Comment 9 Yusuke Suzuki 2018-04-13 09:08:07 PDT
Created attachment 337892 [details]
Patch

Patch for landing
Comment 10 Yusuke Suzuki 2018-04-13 10:01:46 PDT
Committed r230637: <https://trac.webkit.org/changeset/230637>
Comment 11 Radar WebKit Bug Importer 2018-04-13 10:03:34 PDT
<rdar://problem/39415033>