Bug 184388

Summary:

[WPE] xkbcommon: ERROR: failed to add default include path /home/mcatanzaro/Projects/WebKit/WebKitBuild/DependenciesWPE/Root/share/X11/xkb

Product:

WebKit

Reporter:

Michael Catanzaro <mcatanzaro>

Component:

WPE WebKit

Assignee:

Michael Catanzaro <mcatanzaro>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aperez, bugs-noreply, clopez, commit-queue, ews-watchlist, mcatanzaro

Priority:

Version:

WebKit Nightly Build

Hardware:

OS:

Linux

Bug Depends on:

Bug Blocks:

178894

Attachments:

Description	Flags
Patch	none
Patch	none

Description Michael Catanzaro 2018-04-07 12:53:37 PDT

I'm trying to run dinghy in WPE's JHBuild environment, but WPEBackend-mesa is crashing on startup in libxkbcommon:

xkbcommon: ERROR: failed to add default include path /home/mcatanzaro/Projects/WebKit/WebKitBuild/DependenciesWPE/Root/share/X11/xkb

Problem is all the data files are missing. We need to either (a) add them to the jhbuild, or (b) remove xkbcommon.

I kinda think (b) makes more sense, because nothing else in the jhbuild depends on it, and we can surely add it to install-dependencies instead. Right?

But here's a patch for (a) anyway.

Comment 1 Michael Catanzaro 2018-04-07 12:56:38 PDT

Created attachment 337431 [details]
Patch

Comment 2 Michael Catanzaro 2018-04-12 16:05:11 PDT

Since nobody said anything, let's remove xkbcommon.

Comment 3 Michael Catanzaro 2018-04-12 16:25:10 PDT

Created attachment 337847 [details]
Patch

Comment 4 Carlos Alberto Lopez Perez 2018-04-12 17:27:36 PDT

dyz seems to depend on this.

dyz (master) $ git log -1 --oneline
74a368c Add wpebackend.lua to LUA_SRCS list.
dyz (master) $ git grep -i xkbc

src/Makefile:WLGLUE_CFLAGS := $(shell pkg-config egl glib-2.0 wayland-client wayland-egl glesv2 wpe xkbcommon --cflags)
src/Makefile:WLGLUE_LDLIBS := $(shell pkg-config egl glib-2.0 wayland-client wayland-egl glesv2 wpe xkbcommon --libs)
src/wlglue.cpp:#include <xkbcommon/xkbcommon.h>
src/wlglue.cpp:#include <xkbcommon/xkbcommon-compose.h>

Comment 5 Michael Catanzaro 2018-04-13 08:53:53 PDT

That's why I added it to install-dependencies.

I did test to verify that I can run dyz if and only if libxkbcommon is removed from the jhbuild environment. Adding xkeyboard-config also works, but there seems to be no reason to keep libxkbcommon there, so....

Comment 6 Carlos Alberto Lopez Perez 2018-04-13 09:00:56 PDT

Comment on attachment 337847 [details]
Patch

ok, let's try

Comment 7 WebKit Commit Bot 2018-04-13 09:29:13 PDT

Comment on attachment 337847 [details]
Patch

Clearing flags on attachment: 337847

Committed r230634: <https://trac.webkit.org/changeset/230634>

Comment 8 WebKit Commit Bot 2018-04-13 09:29:15 PDT

All reviewed patches have been landed.  Closing bug.