| Summary: | MediaSessionManageriOS should defer creation of MPVolumeView until it needs to monitor AirPlay routes | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jeremy Jones <jeremyj-wk> | ||||||
| Component: | Media | Assignee: | Jeremy Jones <jeremyj-wk> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, fred.wang, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Jeremy Jones
2018-04-06 16:21:01 PDT
Created attachment 337402 [details]
Patch
Comment on attachment 337402 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337402&action=review > Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:429 > + BEGIN_BLOCK_OBJC_EXCEPTIONS > + [routingController setDiscoveryMode:MPRouteDiscoveryModeDisabled]; > + volumeView.clear(); > + routingController.clear(); > + END_BLOCK_OBJC_EXCEPTIONS This is the same as the block in -dealloc, can they be shared? (In reply to Eric Carlson from comment #3) > Comment on attachment 337402 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=337402&action=review > > > Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:429 > > + BEGIN_BLOCK_OBJC_EXCEPTIONS > > + [routingController setDiscoveryMode:MPRouteDiscoveryModeDisabled]; > > + volumeView.clear(); > > + routingController.clear(); > > + END_BLOCK_OBJC_EXCEPTIONS > > This is the same as the block in -dealloc, can they be shared? I can actually share it in three places. Created attachment 337506 [details]
Patch for landing
Comment on attachment 337506 [details] Patch for landing Clearing flags on attachment: 337506 Committed r230490: <https://trac.webkit.org/changeset/230490> |