Summary: | GraphicsLayerCA::createPlatformCALayer always disables extended color in its backing store | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||||
Component: | Layout and Rendering | Assignee: | Brent Fulgham <bfulgham> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, commit-queue, dino, ews-watchlist, simon.fraser, webkit-bug-importer, zalan | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 184364 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Brent Fulgham
2018-04-06 14:21:33 PDT
Are you saying that screenSupportsExtendedColor() always returns false here? (In reply to Simon Fraser (smfr) from comment #2) > Are you saying that screenSupportsExtendedColor() always returns false here? Yes. I think all instances of ‘GraphicsLayerCA::initialize result in a backing store that lacks extended color support. I talked with Dino about this on Friday, and he thinks it is unlikely to create visible problems, it that the backing store is technically wrong in these devices. Created attachment 337610 [details]
Patch
Comment on attachment 337610 [details] Patch Attachment 337610 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7281146 New failing tests: http/tests/security/canvas-remote-read-remote-video-localhost.html Created attachment 337689 [details]
Archive of layout-test-results from ews206 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 337610 [details]
Patch
I wish we could test this.
Comment on attachment 337689 [details]
Archive of layout-test-results from ews206 for win-future
There is no way a change in a Mac-specific file would cause these Windows failures.
Committed r230542: <https://trac.webkit.org/changeset/230542> |