Bug 184325

Summary:

fetch() with subresource integrity crashes on zero length body

Product:

WebKit

Reporter:

Lars Mikkelsen <lars>

Component:

Page Loading

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, beidson, cdumez, commit-queue, dbates, ddkilzer, ews-watchlist, japhet, rbuis, rniwa, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

macOS 10.13

Attachments:

Description	Flags
com.apple.WebKit.WebContent.crash	none
Patch	none
Patch	none
Archive of layout-test-results from ews100 for mac-sierra	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
Archive of layout-test-results from ews112 for mac-sierra	none
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
Patch	none

Lars Mikkelsen

Reported 2018-04-04 18:07:12 PDT

If the 'integrity' option is used for the fetch() method it will cause a crash when the response has a zero length body. This is reproducible using: fetch('https://httpbin.org/bytes/0', {integrity: 'sha256-47DEQpj8HBSa+/TImW+5JCeuQeRkm5NMpJWZG3hSuFU='}); This affects at least Safari 11.1, Safari Technology Preview 53, and WebKit r230285.

Attachments
com.apple.WebKit.WebContent.crash (115.44 KB, text/plain) 2018-04-04 18:10 PDT, Lars Mikkelsen	no flags	Details
Patch (2.06 KB, patch) 2018-08-06 08:36 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (5.43 KB, patch) 2018-08-06 23:58 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-sierra (2.29 MB, application/zip) 2018-08-07 01:03 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.79 MB, application/zip) 2018-08-07 01:10 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews112 for mac-sierra (3.02 MB, application/zip) 2018-08-07 01:37 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.37 MB, application/zip) 2018-08-07 01:50 PDT, EWS Watchlist	no flags	Details
Patch (6.18 KB, patch) 2018-08-07 05:12 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Lars Mikkelsen

Comment 1 2018-04-04 18:10:29 PDT

Created attachment 337247 [details] com.apple.WebKit.WebContent.crash

Radar WebKit Bug Importer

Comment 2 2018-04-07 17:05:22 PDT

<rdar://problem/39262568>

Rob Buis

Comment 3 2018-08-06 08:36:47 PDT

Created attachment 346628 [details] Patch

EWS Watchlist

Comment 4 2018-08-06 10:49:51 PDT

Attachment 346628 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Rob Buis

Comment 5 2018-08-06 23:58:49 PDT

Created attachment 346689 [details] Patch

EWS Watchlist

Comment 6 2018-08-07 01:03:51 PDT

Comment on attachment 346689 [details] Patch Attachment 346689 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/8785226 New failing tests: http/tests/subresource-integrity/sri-fetch-worker.html

EWS Watchlist

Comment 7 2018-08-07 01:03:53 PDT

Created attachment 346691 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 8 2018-08-07 01:10:00 PDT

Comment on attachment 346689 [details] Patch Attachment 346689 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8785244 New failing tests: http/tests/subresource-integrity/sri-fetch-worker.html

EWS Watchlist

Comment 9 2018-08-07 01:10:01 PDT

Created attachment 346692 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 10 2018-08-07 01:37:29 PDT

Comment on attachment 346689 [details] Patch Attachment 346689 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/8785303 New failing tests: http/tests/subresource-integrity/sri-fetch-worker.html

EWS Watchlist

Comment 11 2018-08-07 01:37:31 PDT

Created attachment 346694 [details] Archive of layout-test-results from ews112 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 12 2018-08-07 01:50:56 PDT

Comment on attachment 346689 [details] Patch Attachment 346689 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/8785321 New failing tests: http/tests/subresource-integrity/sri-fetch-worker.html

EWS Watchlist

Comment 13 2018-08-07 01:50:58 PDT

Created attachment 346696 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4

Rob Buis

Comment 14 2018-08-07 05:12:06 PDT

Created attachment 346705 [details] Patch

Alex Christensen

Comment 15 2018-08-07 15:59:22 PDT

Comment on attachment 346705 [details] Patch Great!

WebKit Commit Bot

Comment 16 2018-08-07 16:26:54 PDT

Comment on attachment 346705 [details] Patch Clearing flags on attachment: 346705 Committed r234678: <https://trac.webkit.org/changeset/234678>

WebKit Commit Bot

Comment 17 2018-08-07 16:26:56 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.