Bug 184315

Summary:

Add a test for scoped cookies used to load AppCache resources

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebCore Misc.

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, commit-queue, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Fixing flakiness	none

youenn fablet

Reported 2018-04-04 14:29:31 PDT

Add a test for scoped cookies used to load AppCache resources

Attachments
Patch (5.55 KB, patch) 2018-04-04 14:30 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (6.15 KB, patch) 2018-04-05 21:10 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Fixing flakiness (6.29 KB, patch) 2018-04-05 21:56 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2018-04-04 14:30:44 PDT

Created attachment 337227 [details] Patch

Ryosuke Niwa

Comment 2 2018-04-04 15:45:20 PDT

Comment on attachment 337227 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337227&action=review > LayoutTests/http/tests/appcache/document-cookie-http-only.php:-2 > -setcookie("foo", "bar", 0, "/", null, null, true); Don't we want to keep the test for regular cookies?

youenn fablet

Comment 3 2018-04-04 16:02:47 PDT

(In reply to Ryosuke Niwa from comment #2) > Comment on attachment 337227 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=337227&action=review > > > LayoutTests/http/tests/appcache/document-cookie-http-only.php:-2 > > -setcookie("foo", "bar", 0, "/", null, null, true); > > Don't we want to keep the test for regular cookies? The test is moving from using one HttpOnly cookie to two HttpOnly cookies. So we are not losing coverage here. We have other tests that are covering non HttpOnly cookies. It would be easy to modify this test to cache another script protected by a regular non-scoped cookie. Is that your suggestion?

Ryosuke Niwa

Comment 4 2018-04-04 18:57:55 PDT

(In reply to youenn fablet from comment #3) > (In reply to Ryosuke Niwa from comment #2) > > Comment on attachment 337227 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=337227&action=review > > > > > LayoutTests/http/tests/appcache/document-cookie-http-only.php:-2 > > > -setcookie("foo", "bar", 0, "/", null, null, true); > > > > Don't we want to keep the test for regular cookies? > > The test is moving from using one HttpOnly cookie to two HttpOnly cookies. > So we are not losing coverage here. > > We have other tests that are covering non HttpOnly cookies. > > It would be easy to modify this test to cache another script protected by a > regular non-scoped cookie. Is that your suggestion? Yes, that's my suggestion.

youenn fablet

Comment 5 2018-04-05 21:10:08 PDT

Created attachment 337342 [details] Patch

youenn fablet

Comment 6 2018-04-05 21:56:40 PDT

Created attachment 337345 [details] Fixing flakiness

WebKit Commit Bot

Comment 7 2018-04-05 23:47:36 PDT

Comment on attachment 337345 [details] Fixing flakiness Clearing flags on attachment: 337345 Committed r230328: <https://trac.webkit.org/changeset/230328>

WebKit Commit Bot

Comment 8 2018-04-05 23:47:37 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 9 2018-04-05 23:48:23 PDT

<rdar://problem/39231738>

Note You need to log in before you can comment on or make changes to this bug.