Bug 184301

Summary: Enable Gigacage unconditionally when building JSCOnly on macOS (build fix)
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: bmallocAssignee: Konstantin Tokarev <annulen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, jfbastien, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ysuzuki: review+, annulen: commit-queue+

Description Konstantin Tokarev 2018-04-04 06:56:32 PDT 
bmalloc/ProcessCheck.mm implements specific behavior for Mac and iOS ports, which is guarded with BPLATFORM(COCOA). We should not enable BPLATFORM(MAC) or BPLATFORM(IOS) in JSCOnly, then BPLATFORM(COCOA) won't be defined as well, and code path from ProcessCheck.mm will not be taken
Comment 1 Konstantin Tokarev 2018-04-04 07:00:56 PDT 
Created attachment 337162 [details]
Patch
Comment 2 Yusuke Suzuki 2018-04-04 07:02:19 PDT 
Comment on attachment 337162 [details]
Patch

r=me
Comment 3 Konstantin Tokarev 2018-04-04 07:03:06 PDT 
Should fix GTK/macOS too.
Comment 4 Konstantin Tokarev 2018-04-04 07:17:05 PDT 
Created attachment 337163 [details]
Patch
Comment 5 Konstantin Tokarev 2018-04-04 07:17:32 PDT 
Now it should actually fix GTK/macOS
Comment 6 Yusuke Suzuki 2018-04-04 07:28:48 PDT 
Comment on attachment 337163 [details]
Patch

r=me since Mac does not have maintained CMake port right now.
Comment 7 Konstantin Tokarev 2018-04-04 07:31:20 PDT 
Note that I've defined BPLATFORM_MAC in PlatformMac, so it should not make things worse for Mac/CMake
Comment 8 Konstantin Tokarev 2018-04-04 08:00:29 PDT 
Committed r230255: <https://trac.webkit.org/changeset/230255>
Comment 9 Radar WebKit Bug Importer 2018-04-04 08:02:19 PDT 
<rdar://problem/39174671>