Bug 184296

Summary:

[Win][WebCore] Expose a constant for scrollbar pixels per line (cScrollbarPixelsPerLine)

Product:

WebKit

Reporter:

Fujii Hironori <Hironori.Fujii>

Component:

Platform

Assignee:

Fujii Hironori <Hironori.Fujii>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bfulgham, commit-queue, don.olmstead, pvollan, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

183043

Attachments:

Description	Flags
Patch	none
Patch	none

Description Fujii Hironori 2018-04-04 03:29:08 PDT

[Win][WebCore] New API to get scrollbar pixels per line (cScrollbarPixelsPerLine)

A constant `cScrollbarPixelsPerLine` is defined in multiple codes.

WebCore/platform/win/WheelEventWin.cpp
DumpRenderTree/win/EventSender.cpp

Comment 1 Fujii Hironori 2018-04-04 03:35:31 PDT

(In reply to Brent Fulgham from bug#183043 comment #5)
> > Source/WebKit/Shared/win/WebEventFactory.cpp:400
> > +    static const float cScrollbarPixelsPerLine = 100.0f / 3.0f;
> 
> We should probably expose this from WebCore in some useful way, since we now
> have this hard-coded in two places.

Comment 2 Fujii Hironori 2018-04-04 03:45:01 PDT

Created attachment 337155 [details]
Patch

Comment 3 Alex Christensen 2018-04-04 09:49:48 PDT

Comment on attachment 337155 [details]
Patch

This doubles the calls to ::GetDeviceCaps when scrolling.

Comment 4 Fujii Hironori 2018-04-05 20:37:02 PDT

Created attachment 337337 [details]
Patch

Comment 5 WebKit Commit Bot 2018-04-06 13:30:21 PDT

Comment on attachment 337337 [details]
Patch

Clearing flags on attachment: 337337

Committed r230355: <https://trac.webkit.org/changeset/230355>

Comment 6 WebKit Commit Bot 2018-04-06 13:30:22 PDT

All reviewed patches have been landed.  Closing bug.

Comment 7 Radar WebKit Bug Importer 2018-04-06 13:31:19 PDT

<rdar://problem/39247433>