Summary: | [SOUP] Stop using ResourceHandle to load GResources | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cdumez, dbates, ews-watchlist, japhet, svillar, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 184048 | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2018-04-03 03:16:39 PDT
Created attachment 337068 [details]
Patch
Comment on attachment 337068 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337068&action=review > Source/WebCore/platform/glib/SharedBufferGlib.cpp:30 > +SharedBuffer::SharedBuffer(GBytes* bytes) I guess this can be a reference since it cannot be null. > Source/WebCore/platform/glib/SharedBufferGlib.cpp:37 > +Ref<SharedBuffer> SharedBuffer::create(GBytes* bytes) Ditto. (In reply to Sergio Villar Senin from comment #2) > Comment on attachment 337068 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=337068&action=review > > > Source/WebCore/platform/glib/SharedBufferGlib.cpp:30 > > +SharedBuffer::SharedBuffer(GBytes* bytes) > > I guess this can be a reference since it cannot be null. Nop, we never use references for C structs. > > Source/WebCore/platform/glib/SharedBufferGlib.cpp:37 > > +Ref<SharedBuffer> SharedBuffer::create(GBytes* bytes) > > Ditto. Committed r230203: <https://trac.webkit.org/changeset/230203> (In reply to Carlos Garcia Campos from comment #3) > (In reply to Sergio Villar Senin from comment #2) > > Comment on attachment 337068 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=337068&action=review > > > > > Source/WebCore/platform/glib/SharedBufferGlib.cpp:30 > > > +SharedBuffer::SharedBuffer(GBytes* bytes) > > > > I guess this can be a reference since it cannot be null. > > Nop, we never use references for C structs. :) next time I'll check the actual type |