Bug 184241

Summary: Define AVKit softlink macro
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Eric Carlson
Reported 2018-04-02 11:38:50 PDT
Define AVKit softlink macro
Attachments
Patch (6.52 KB, patch)
2018-04-02 12:46 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2018-04-02 12:46:54 PDT
Created attachment 337014 [details] Patch
Radar WebKit Bug Importer
Comment 2 2018-04-02 12:47:56 PDT
<rdar://problem/39115023>
Jer Noble
Comment 3 2018-04-02 13:03:21 PDT
Comment on attachment 337014 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337014&action=review > Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.h:39 > +#if ENABLE(EXTRA_ZOOM_MODE) > +#define SOFTLINK_AVKIT_FRAMEWORK() SOFT_LINK_PRIVATE_FRAMEWORK_OPTIONAL(AVKit) > +#else > +#define SOFTLINK_AVKIT_FRAMEWORK() SOFT_LINK_FRAMEWORK_OPTIONAL(AVKit) > +#endif > + Nit: We should eventually move this into an "AVKitSoftLink.h" header and matching source file.
WebKit Commit Bot
Comment 4 2018-04-02 13:34:13 PDT
Comment on attachment 337014 [details] Patch Clearing flags on attachment: 337014 Committed r230177: <https://trac.webkit.org/changeset/230177>
WebKit Commit Bot
Comment 5 2018-04-02 13:34:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.