Bug 184179

Summary:

Update messages.py codegen for String, fix tests

Product:

WebKit

Reporter:

JF Bastien <jfbastien>

Component:

WebKit Misc.

Assignee:

JF Bastien <jfbastien>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, commit-queue, ews-watchlist, jfbastien, mark.lam, ryanhaddad, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

184172

Bug Blocks:

184164

Attachments:

Description	Flags
patch	jfbastien: commit-queue-
patch	mark.lam: review+
patch	none

JF Bastien

Reported 2018-03-30 09:06:20 PDT

I updated some of the code in https://trac.webkit.org/changeset/230097 and auto-magically used a script to update copyright headers... and that broke the tests which checked for a particular date. Update all of the headers.

Attachments
patch (3.83 KB, patch) 2018-03-30 09:07 PDT, JF Bastien	jfbastien: commit-queue-	Details Formatted Diff Diff
patch (7.95 KB, patch) 2018-03-30 09:28 PDT, JF Bastien	mark.lam: review+	Details Formatted Diff Diff
patch (7.92 KB, patch) 2018-03-30 09:51 PDT, JF Bastien	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

JF Bastien

Comment 1 2018-03-30 09:07:51 PDT

Created attachment 336857 [details] patch

JF Bastien

Comment 2 2018-03-30 09:08:24 PDT

This should fix the issue. I'm not sure how we usually run these tests though. Looking...

JF Bastien

Comment 3 2018-03-30 09:09:36 PDT

Comment on attachment 336857 [details] patch Looks borked still, with further things...

Radar WebKit Bug Importer

Comment 4 2018-03-30 09:26:40 PDT

<rdar://problem/39041352>

JF Bastien

Comment 5 2018-03-30 09:28:38 PDT

Created attachment 336861 [details] patch Actual fix, passing all tests and updating messages.py's generated code as I had done in https://bugs.webkit.org/show_bug.cgi?id=184164

EWS Watchlist

Comment 6 2018-03-30 09:30:14 PDT

Attachment 336861 [details] did not pass style-queue: ERROR: Source/WebKit/Scripts/webkit/messages_unittest.py:308: trailing whitespace [pep8/W291] [5] ERROR: Source/WebKit/Scripts/webkit/messages_unittest.py:313: trailing whitespace [pep8/W291] [5] ERROR: Source/WebKit/Scripts/webkit/messages_unittest.py:316: trailing whitespace [pep8/W291] [5] Total errors found: 3 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

JF Bastien

Comment 7 2018-03-30 09:51:23 PDT

Created attachment 336864 [details] patch Fix whitespace.

Mark Lam

Comment 8 2018-03-30 10:05:00 PDT

Comment on attachment 336861 [details] patch LGTM.

WebKit Commit Bot

Comment 9 2018-03-30 10:30:22 PDT

Comment on attachment 336864 [details] patch Clearing flags on attachment: 336864 Committed r230108: <https://trac.webkit.org/changeset/230108>

WebKit Commit Bot

Comment 10 2018-03-30 10:30:24 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.