Bug 184175

Summary: Add pointer profiling support to Wasm.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, jfbastien, keith_miller, msaboff, rmorisset, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. jfbastien: review+

Description Mark Lam 2018-03-29 22:43:36 PDT 
Patch coming.
Comment 1 Radar WebKit Bug Importer 2018-03-29 22:44:13 PDT 
<rdar://problem/39027923>
Comment 2 Mark Lam 2018-03-29 23:01:46 PDT 
Created attachment 336842 [details]
proposed patch.
Comment 3 JF Bastien 2018-03-30 08:46:57 PDT 
Comment on attachment 336842 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=336842&action=review

r=me this is great! :D

> Source/JavaScriptCore/wasm/js/WebAssemblyFunction.h:72
> +        return m_jsEntrypoint.retagged(CodeEntryPtrTag, CodeEntryWithArityCheckPtrTag);

Right now vmEntryToWebAssembly is the same thing as vmEntryToJavaScript. Should we split them and use different CodeEntryPtrTag?
Comment 4 Mark Lam 2018-03-30 09:26:54 PDT 
Comment on attachment 336842 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=336842&action=review

Thanks for the review.

>> Source/JavaScriptCore/wasm/js/WebAssemblyFunction.h:72
>> +        return m_jsEntrypoint.retagged(CodeEntryPtrTag, CodeEntryWithArityCheckPtrTag);
> 
> Right now vmEntryToWebAssembly is the same thing as vmEntryToJavaScript. Should we split them and use different CodeEntryPtrTag?

Let's only make a change when the need arises later.
Comment 5 Mark Lam 2018-03-30 09:32:52 PDT 
Landed in r230106: <http://trac.webkit.org/r230106>.