Bug 184172

Summary: Use Forward.h instead of forward-declaring WTF::String
Product: WebKit Reporter: JF Bastien <jfbastien>
Component: Web Template FrameworkAssignee: JF Bastien <jfbastien>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, ews-watchlist, jfbastien, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 184164, 184179    
Attachments:
Description Flags
patch none

JF Bastien
Reported 2018-03-29 21:12:11 PDT
As part of #184164 I'm changing WTF::String, and the forward declarations are just wrong because I'm making it templated. We should use Forward.h anyways, so do that instead.
Attachments
patch (18.27 KB, patch)
2018-03-29 21:16 PDT, JF Bastien 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-03-29 21:12:42 PDT
<rdar://problem/39026146>
JF Bastien
Comment 2 2018-03-29 21:16:56 PDT
Created attachment 336839 [details] patch
EWS Watchlist
Comment 3 2018-03-29 21:18:47 PDT
Attachment 336839 [details] did not pass style-queue: ERROR: Source/WTF/wtf/PrintStream.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/ios/Device.h:31: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yusuke Suzuki
Comment 4 2018-03-29 21:39:13 PDT
Comment on attachment 336839 [details] patch r=me
WebKit Commit Bot
Comment 5 2018-03-29 22:05:20 PDT
Comment on attachment 336839 [details] patch Clearing flags on attachment: 336839 Committed r230097: <https://trac.webkit.org/changeset/230097>
WebKit Commit Bot
Comment 6 2018-03-29 22:05:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.