Bug 184162

Summary: Followup(r230063): Add test a layout test for https://bugs.webkit.org/show_bug.cgi?id=183972
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: SVGAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, dbates, ryanhaddad, webkit-bug-importer, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 183972    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Said Abou-Hallawa
Reported 2018-03-29 16:13:51 PDT
I wrote a layout test for https://bugs.webkit.org/show_bug.cgi?id=183972 and I spent some time trying to get it to crash without the patch. But I could not get the test to crash so I went ahead and I landed r230063. I then realized it is actually worthy to add such test to ensure the SVG tear-off objects are more robust.
Attachments
Patch (3.78 KB, patch)
2018-03-29 16:16 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (3.75 KB, patch)
2018-03-30 07:45 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2018-03-29 16:16:49 PDT
Created attachment 336816 [details] Patch
Said Abou-Hallawa
Comment 2 2018-03-30 07:45:04 PDT
Created attachment 336853 [details] Patch
Ryan Haddad
Comment 3 2018-03-31 14:09:06 PDT
I'm not sure why this patch is still stuck waiting for EWS. I released all the locks and resubmitted it, but apparently that didn't help.
Daniel Bates
Comment 4 2018-04-02 10:27:23 PDT
Comment on attachment 336853 [details] Patch Thanks for taking the time to write a test! r=me
Said Abou-Hallawa
Comment 5 2018-04-02 12:42:44 PDT
Committed r230172: <https://trac.webkit.org/changeset/230172>
Radar WebKit Bug Importer
Comment 6 2018-04-02 12:43:35 PDT
<rdar://problem/39114918>
Aakash Jain
Comment 7 2018-04-02 14:52:46 PDT
(In reply to Ryan Haddad from comment #3) > I'm not sure why this patch is still stuck waiting for EWS. I released all > the locks and resubmitted it, but apparently that didn't help. This is hitting https://bugs.webkit.org/show_bug.cgi?id=171463 (<rdar://problem/31894087>). The issue is that the bug title contains another bug id which confuses EWS.
Note You need to log in before you can comment on or make changes to this bug.