Summary: | [GTK] DragAndDropHandler.cpp should include GUniquePtrGtk.h | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> | ||||
Component: | WebKitGTK | Assignee: | Michael Catanzaro <mcatanzaro> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bugs-noreply, cgarcia, dbates, mcatanzaro | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Michael Catanzaro
2018-03-28 17:13:00 PDT
Created attachment 336736 [details]
Patch
Comment on attachment 336736 [details]
Patch
OK
Comment on attachment 336736 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336736&action=review > Source/WebKit/UIProcess/gtk/DragAndDropHandler.cpp:31 > +#include "GUniquePtrGtk.h" This is a WebCoire header included in WebKLit layer, please use <WebCore/GUniquePtrGtk.h> instead. Whoops, must have gotten confused. And also forgot about this. Actually this tells me we have a bug with our include paths: that really should not have compiled at all. :/ (In reply to Michael Catanzaro from comment #5) > Actually this tells me we have a bug with our include paths: that really > should not have compiled at all. :/ I guess it's because we use PUBLIC include directories everywhere. CMake is wonderful that way.... Committed r230156: <https://trac.webkit.org/changeset/230156> |