|Summary:||[GTK] DragAndDropHandler.cpp should include GUniquePtrGtk.h|
|Product:||WebKit||Reporter:||Michael Catanzaro <mcatanzaro>|
|Component:||WebKitGTK||Assignee:||Michael Catanzaro <mcatanzaro>|
|Severity:||Normal||CC:||bugs-noreply, cgarcia, dbates, mcatanzaro|
|Version:||WebKit Nightly Build|
Description Michael Catanzaro 2018-03-28 17:13:00 PDT
We've failed to figure out why, but in some build configurations, GUniquePtrGtk.h doesn't get pulled in and the unique_ptrs use the wrong deleter function. This file should include what it needs.
Comment 3 Carlos Garcia Campos 2018-04-02 00:45:38 PDT
Comment on attachment 336736 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336736&action=review > Source/WebKit/UIProcess/gtk/DragAndDropHandler.cpp:31 > +#include "GUniquePtrGtk.h" This is a WebCoire header included in WebKLit layer, please use <WebCore/GUniquePtrGtk.h> instead.
Comment 4 Michael Catanzaro 2018-04-02 07:29:00 PDT
Whoops, must have gotten confused. And also forgot about this.
Comment 5 Michael Catanzaro 2018-04-02 07:29:52 PDT
Actually this tells me we have a bug with our include paths: that really should not have compiled at all. :/
Comment 6 Michael Catanzaro 2018-04-02 07:30:19 PDT
(In reply to Michael Catanzaro from comment #5) > Actually this tells me we have a bug with our include paths: that really > should not have compiled at all. :/ I guess it's because we use PUBLIC include directories everywhere. CMake is wonderful that way....