Bug 184119

Summary: [GTK] DragAndDropHandler.cpp should include GUniquePtrGtk.h
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, dbates, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch dbates: review+, cgarcia: commit-queue-

Michael Catanzaro
Reported 2018-03-28 17:13:00 PDT
We've failed to figure out why, but in some build configurations, GUniquePtrGtk.h doesn't get pulled in and the unique_ptrs use the wrong deleter function. This file should include what it needs.
Attachments
Patch (1.38 KB, patch)
2018-03-28 17:13 PDT, Michael Catanzaro 		dbates: review+
cgarcia: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2018-03-28 17:13:45 PDT
Created attachment 336736 [details] Patch
Daniel Bates
Comment 2 2018-03-28 23:35:44 PDT
Comment on attachment 336736 [details] Patch OK
Carlos Garcia Campos
Comment 3 2018-04-02 00:45:38 PDT
Comment on attachment 336736 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336736&action=review > Source/WebKit/UIProcess/gtk/DragAndDropHandler.cpp:31 > +#include "GUniquePtrGtk.h" This is a WebCoire header included in WebKLit layer, please use <WebCore/GUniquePtrGtk.h> instead.
Michael Catanzaro
Comment 4 2018-04-02 07:29:00 PDT
Whoops, must have gotten confused. And also forgot about this.
Michael Catanzaro
Comment 5 2018-04-02 07:29:52 PDT
Actually this tells me we have a bug with our include paths: that really should not have compiled at all. :/
Michael Catanzaro
Comment 6 2018-04-02 07:30:19 PDT
(In reply to Michael Catanzaro from comment #5) > Actually this tells me we have a bug with our include paths: that really > should not have compiled at all. :/ I guess it's because we use PUBLIC include directories everywhere. CMake is wonderful that way....
Michael Catanzaro
Comment 7 2018-04-02 07:42:39 PDT
Committed r230156: <https://trac.webkit.org/changeset/230156>
Note You need to log in before you can comment on or make changes to this bug.