Bug 184117

Summary: run-jsc-benchmarks should recognize Windows-style build directory structure.
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: Tools / TestsAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, keith_miller, lforschler, mark.lam, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Ross Kirsling
Reported 2018-03-28 16:38:54 PDT
run-jsc-benchmarks should recognize Windows-style build directory structure.
Attachments
Patch (1.90 KB, patch)
2018-03-28 16:39 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.88 KB, patch)
2018-03-29 20:10 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2018-03-28 16:39:43 PDT
Created attachment 336733 [details] Patch
Yusuke Suzuki
Comment 2 2018-03-29 19:04:10 PDT
Comment on attachment 336733 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336733&action=review r=me with some nits > Tools/Scripts/run-jsc-benchmarks:1345 > + elsif @path =~ /\/Release\/bin(64|32|)\/([.a-zA-Z]+)$/ I think `[.a-zA-Z]` should be `[\.a-zA-Z]`. > Tools/Scripts/run-jsc-benchmarks:1347 > + elsif @path =~ /\/Debug\/bin(64|32|)\/([.a-zA-Z]+)$/ Ditto.
Ross Kirsling
Comment 3 2018-03-29 20:10:37 PDT
Created attachment 336835 [details] Patch for landing
WebKit Commit Bot
Comment 4 2018-03-29 21:35:12 PDT
Comment on attachment 336835 [details] Patch for landing Clearing flags on attachment: 336835 Committed r230093: <https://trac.webkit.org/changeset/230093>
WebKit Commit Bot
Comment 5 2018-03-29 21:35:14 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-03-29 21:36:21 PDT
<rdar://problem/39026716>
Note You need to log in before you can comment on or make changes to this bug.