Bug 184112

Summary: Drop DOMWindow::frames() / DOMWindow::window() methods
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, berto, cdumez, cgarcia, commit-queue, dbates, esprehn+autocc, ews-watchlist, gustavo, kondapallykalyan, mcatanzaro, rniwa, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2018-03-28 15:09:18 PDT
Drop DOMWindow::frames() / DOMWindow::window() methods as they are just aliases for DOMWindow::self().
Attachments
Patch (2.58 KB, patch)
2018-03-28 15:10 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (3.91 KB, patch)
2018-03-29 09:27 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2018-03-28 15:10:24 PDT
Created attachment 336724 [details] Patch
Daniel Bates
Comment 2 2018-03-28 23:17:14 PDT
Comment on attachment 336724 [details] Patch r=me
Daniel Bates
Comment 3 2018-03-28 23:21:57 PDT
Comment on attachment 336724 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336724&action=review > Source/WebCore/page/DOMWindow.h:194 > // Self-referential attributes Please remove this comment now that self() is the only self-referential attribute that we have a member function for and its name is self-descriptive. Self :)
Daniel Bates
Comment 4 2018-03-28 23:26:01 PDT
(In reply to Daniel Bates from comment #3) > Comment on attachment 336724 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=336724&action=review > > > Source/WebCore/page/DOMWindow.h:194 > > // Self-referential attributes > > Please remove this comment now that self() is the only self-referential > attribute that we have a member function for and its name is > self-descriptive. Self :) Err, top() is self-referential for the main frame :/
Chris Dumez
Comment 5 2018-03-29 09:27:08 PDT
Created attachment 336777 [details] Patch
EWS Watchlist
Comment 6 2018-03-29 09:29:08 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
WebKit Commit Bot
Comment 7 2018-03-29 09:52:37 PDT
Comment on attachment 336777 [details] Patch Clearing flags on attachment: 336777 Committed r230077: <https://trac.webkit.org/changeset/230077>
WebKit Commit Bot
Comment 8 2018-03-29 09:52:39 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-03-29 09:53:23 PDT
<rdar://problem/39002370>
Note You need to log in before you can comment on or make changes to this bug.