Created attachment 336703[details]
Archive of layout-test-results from ews101 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 336691[details]
Patch
Attachment 336691[details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7127264
New failing tests:
imported/w3c/web-platform-tests/fetch/corb/img-png-mislabeled-as-html.sub.html
imported/w3c/web-platform-tests/fetch/corb/img-png-mislabeled-as-html-nosniff.tentative.sub.html
imported/w3c/web-platform-tests/fetch/corb/img-html-correctly-labeled.sub.html
Created attachment 336707[details]
Archive of layout-test-results from ews107 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 336691[details]
Patch
Attachment 336691[details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/7127711
New failing tests:
imported/w3c/web-platform-tests/fetch/corb/img-png-mislabeled-as-html.sub.html
imported/w3c/web-platform-tests/fetch/corb/img-png-mislabeled-as-html-nosniff.tentative.sub.html
imported/w3c/web-platform-tests/fetch/corb/img-html-correctly-labeled.sub.html
Created attachment 336712[details]
Archive of layout-test-results from ews126 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Created attachment 336713[details]
Archive of layout-test-results from ews115 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6
Attachment 336791[details] did not pass style-queue:
ERROR: LayoutTests/TestExpectations:1783: Path does not exist. [test/expectations] [5]
ERROR: LayoutTests/TestExpectations:1784: Path does not exist. [test/expectations] [5]
ERROR: LayoutTests/TestExpectations:1785: Path does not exist. [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/TestExpectations:1783: Path does not exist. [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/TestExpectations:1784: Path does not exist. [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/TestExpectations:1785: Path does not exist. [test/expectations] [5]
Total errors found: 6 in 64 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 336794[details]
Archive of layout-test-results from ews100 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 336795[details]
Archive of layout-test-results from ews105 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Created attachment 336798[details]
Archive of layout-test-results from ews117 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 336800[details]
Archive of layout-test-results from ews123 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Created attachment 336811[details]
Archive of layout-test-results from ews103 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 336817[details]
Archive of layout-test-results from ews113 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-sierra Platform: Mac OS X 10.12.6
It seems the purpose is to refresh a subset of the tests, right, XHR/fetch subfolders and maybe some others? Maybe this could be stated more precisely in the title.
When doing this kind of full resyncing, I usually do not include new tests.
This is only a matter of taste and it is usually to decrease the size of the patch.
Also I usually update LayoutTests/imported/w3c/resources/TestRepositories revision value so that users doing:
import-w3c-tests web-platform-tests/mytestsuite
will use that specific revision.
Comment on attachment 336855[details]
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=336855&action=review> LayoutTests/ChangeLog:3
> + Resync web-platform-tests up to 42f43956d49feb44ac03a0945a64066dd77e1f6c
You only re-synced fetch tests, which is fine but then please say so in the title.
> LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/abort-after-send-expected.txt:2
> +FAIL XMLHttpRequest: abort() after send() assert_equals: expected "abort(0,0,false)" but got "upload.progress(0,0,false)"
Looks like you may have generated those XMLHttpRequest expectations using an old version of WebKit. I fixed those bugs in trunk recently. I do not believe these XHR rebaselines are correct.
(In reply to Chris Dumez from comment #28)
> Comment on attachment 336855[details]
> Patch
>
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=336855&action=review
>
> > LayoutTests/ChangeLog:3
> > + Resync web-platform-tests up to 42f43956d49feb44ac03a0945a64066dd77e1f6c
>
> You only re-synced fetch tests, which is fine but then please say so in the
> title.
I originally pushed up a patch with just the fetch tests to help me understand how the CI handles changes to the web-platform-test. My last patch was intended to have everything but I seem to have messed something up.
> > LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/abort-after-send-expected.txt:2
> > +FAIL XMLHttpRequest: abort() after send() assert_equals: expected "abort(0,0,false)" but got "upload.progress(0,0,false)"
>
> Looks like you may have generated those XMLHttpRequest expectations using an
> old version of WebKit. I fixed those bugs in trunk recently. I do not
> believe these XHR rebaselines are correct.
I will re-sync to the latest head of webkit and try these expectations again.
(In reply to youenn fablet from comment #27)
> When doing this kind of full resyncing, I usually do not include new tests.
> This is only a matter of taste and it is usually to decrease the size of the
> patch.
I will do that. Do you usually follow up with a second patch to add the new tests?
> Also I usually update LayoutTests/imported/w3c/resources/TestRepositories
> revision value so that users doing:
> import-w3c-tests web-platform-tests/mytestsuite
> will use that specific revision.
Will do.
Created attachment 336858[details]
Archive of layout-test-results from ews100 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 336859[details]
Archive of layout-test-results from ews105 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Created attachment 336862[details]
Archive of layout-test-results from ews123 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Created attachment 336863[details]
Archive of layout-test-results from ews113 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-sierra Platform: Mac OS X 10.12.6
youenn suggested I split this into smaller patches to make it easier to land without conflicts. The first patch is opened as https://bugs.webkit.org/show_bug.cgi?id=184278 . I tried to update this issue with that change but I kept getting network errors when attempting to obsolete the old patch. I'm going to close this issue.
2018-03-28 12:12 PDT, Brendan McLoughlin
2018-03-28 13:02 PDT, EWS Watchlist
2018-03-28 13:08 PDT, EWS Watchlist
2018-03-28 13:48 PDT, EWS Watchlist
2018-03-28 13:49 PDT, EWS Watchlist
2018-03-29 11:24 PDT, Brendan McLoughlin
2018-03-29 11:49 PDT, Brendan McLoughlin
2018-03-29 12:53 PDT, EWS Watchlist
2018-03-29 12:59 PDT, EWS Watchlist
2018-03-29 13:26 PDT, EWS Watchlist
2018-03-29 13:28 PDT, EWS Watchlist
2018-03-29 14:43 PDT, Brendan McLoughlin
2018-03-29 15:51 PDT, EWS Watchlist
2018-03-29 16:24 PDT, EWS Watchlist
2018-03-30 08:07 PDT, Brendan McLoughlin
2018-03-30 09:15 PDT, EWS Watchlist
2018-03-30 09:19 PDT, EWS Watchlist
2018-03-30 09:50 PDT, EWS Watchlist
2018-03-30 09:51 PDT, EWS Watchlist
2018-03-30 14:42 PDT, Brendan McLoughlin
2018-04-03 11:22 PDT, Brendan McLoughlin