Bug 184093

Summary: Rename UNUSED to BUNUSED
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: bmallocAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, fpizlo, ggaren, mcatanzaro, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch none

Michael Catanzaro
Reported 2018-03-28 09:58:07 PDT
Should we rename UNUSED to BUNUSED? This would make it less likely to be misused outside of bmalloc, as I did in bug #184081.
Attachments
Patch (2.22 KB, patch)
2018-03-28 09:58 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Patch (3.65 KB, patch)
2018-03-28 17:32 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2018-03-28 09:58:55 PDT
Created attachment 336669 [details] Patch
Michael Catanzaro
Comment 2 2018-03-28 17:32:01 PDT
Created attachment 336738 [details] Patch
Michael Catanzaro
Comment 3 2018-04-09 17:28:19 PDT
Pinging bmalloc reviewers!
Yusuke Suzuki
Comment 4 2018-04-09 17:32:19 PDT
Comment on attachment 336738 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336738&action=review r=me > Source/bmalloc/bmalloc/BAssert.h:103 > +#define BUNUSED(x) ((void)x) renaming this to `BUNUSED_PARAM` would be good. But either is OK to me.
Michael Catanzaro
Comment 5 2018-04-09 18:12:44 PDT
Comment on attachment 336738 [details] Patch I kinda prefer BUNUSED, it's short and sweet, but no strong preference here either. Whatever the bmalloc crew prefers.
WebKit Commit Bot
Comment 6 2018-04-09 18:42:50 PDT
Comment on attachment 336738 [details] Patch Clearing flags on attachment: 336738 Committed r230463: <https://trac.webkit.org/changeset/230463>
WebKit Commit Bot
Comment 7 2018-04-09 18:42:52 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-04-09 18:43:20 PDT
<rdar://problem/39301964>
Note You need to log in before you can comment on or make changes to this bug.