Bug 184089

Summary:

[DFG] More aggressive removal of duplicate 32bit DFG code

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

New Bugs

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, darin, ews-watchlist, fpizlo, keith_miller, mark.lam, msaboff, saam, sam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Yusuke Suzuki

Reported 2018-03-28 09:12:50 PDT

[DFG] More aggressive removal of 32bit DFG

Attachments
Patch (69.17 KB, patch) 2018-03-28 09:13 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (69.24 KB, patch) 2018-03-28 19:23 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (69.25 KB, patch) 2018-03-28 19:28 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (69.37 KB, patch) 2018-03-29 19:18 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Yusuke Suzuki

Comment 1 2018-03-28 09:13:41 PDT

Created attachment 336662 [details] Patch

Saam Barati

Comment 2 2018-03-28 11:44:20 PDT

Comment on attachment 336662 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336662&action=review seems like you broke 32-bit x86 builds > Source/JavaScriptCore/ChangeLog:3 > + [DFG] More aggressive removal of 32bit DFG this title should have "duplicate" before "32bit"

Yusuke Suzuki

Comment 3 2018-03-28 19:23:01 PDT

Created attachment 336746 [details] Patch

Yusuke Suzuki

Comment 4 2018-03-28 19:27:54 PDT

OK, updated

Yusuke Suzuki

Comment 5 2018-03-28 19:28:50 PDT

Created attachment 336748 [details] Patch

Yusuke Suzuki

Comment 6 2018-03-29 19:18:58 PDT

Created attachment 336832 [details] Patch