| Summary: | Enhance ARM64 probe to support pointer profiling. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | fpizlo, jfbastien, keith_miller, msaboff, rmorisset, saam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Mark Lam
2018-03-27 19:36:46 PDT
Created attachment 336639 [details]
proposed patch.
Comment on attachment 336639 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=336639&action=review r=me > Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:2146 > + } Assert that the registers aren't the same? (In reply to JF Bastien from comment #3) > > Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:2146 > > + } > > Assert that the registers aren't the same? We talked offline, and concluded that this assertion is not always true. The client is allowed to push the same register twice if desired. So, we'll not add the assert. Thanks for the review. Landed in r230040: <http://trac.webkit.org/r230040>. |