REGRESSION (r229831?): Layout Test http/tests/appcache/interrupted-update.html is a flaky failure

• Component: New Bugs
• Status: RESOLVED FIXED

[Ryan Haddad]

The following layout test is flaky on iOS and macOS

http/tests/appcache/interrupted-update.html

Probable cause:

Unknown, this test became flaky within the last 7 days. The earliest failure seen on the dashboard for macOS blames https://trac.webkit.org/log/webkit/?verbose=on&rev=229746&stop_rev=229746

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fappcache%2Finterrupted-update.html

[Alexey Proskuryakov]

@@ -1,3 +1,5 @@
+CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
+CONSOLE MESSAGE: line 37: Reloading...
 CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
 CONSOLE MESSAGE: line 37: Reloading...
 CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.


There was a new test added in r229733 (http/tests/appcache/document-cookie.php), I wonder if this is somehow caused by it.

[Alexey Proskuryakov]

But bug 180568 is even more suspicious. That change was actually briefly landed, rolled back, and landed again. The test failed once when it was first landed, and then started to fail again after it was re-landed.

[Radar WebKit Bug Importer]

<rdar://problem/38975570>

[youenn fablet]

Created attachment 339952 [details]
Patch

[EWS Watchlist]

Comment on attachment 339952 [details]
Patch

Attachment 339952 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7622605

New failing tests:
http/tests/appcache/interrupted-update.html

[EWS Watchlist]

Created attachment 339956 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 339952 [details]
Patch

Attachment 339952 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7622608

New failing tests:
http/tests/appcache/interrupted-update.html

[EWS Watchlist]

Created attachment 339957 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[youenn fablet]

Created attachment 339982 [details]
Patch

[youenn fablet]

I made http/tests/appcache/interrupted-update.html not rely on local storage which seems to be the cause of the trouble.
I added a local-storage+reload test as a way to continue tracking this potential issue.

[youenn fablet]

ping review

[WebKit Commit Bot]

Comment on attachment 339982 [details]
Patch

Clearing flags on attachment: 339982

Committed r231918: <https://trac.webkit.org/changeset/231918>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.