Bug 184060

Summary: Layout Test imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html is a flaky failure
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: REOPENED ---    
Severity: Normal CC: ap, cdumez, commit-queue, realdawei, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=183294
Attachments:
Description Flags
Patch
none
Patch none

Description Ryan Haddad 2018-03-27 17:09:27 PDT
The following layout test is failing on macOS

imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html

Probable cause:

This test was marked as [ Failure Pass ] until https://trac.webkit.org/changeset/229191/webkit

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fbrowsers%2Fhistory%2Fthe-location-interface%2Flocation-protocol-setter-non-broken.html

--- /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken-expected.txt
+++ /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken-actual.txt
@@ -2,7 +2,7 @@
 PASS Set HTTP URL frame location.protocol to x 
 PASS Set data URL frame location.protocol to x 
 PASS Set HTTP URL frame location.protocol to data 
-FAIL Set data URL frame location.protocol to data The object can not be cloned.
+PASS Set data URL frame location.protocol to data 
 PASS Set HTTP URL frame location.protocol to file 
 PASS Set data URL frame location.protocol to file 
 PASS Set HTTP URL frame location.protocol to ftp
Comment 1 Dawei Fenton (:realdawei) 2018-06-06 17:05:12 PDT
Created attachment 342097 [details]
Patch
Comment 2 youenn fablet 2018-06-06 17:23:50 PDT
Comment on attachment 342097 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342097&action=review

> LayoutTests/ChangeLog:89
> +2018-06-06  David Fenton  <david_fenton@apple.com>

Probably need to remove this log entry.

Bug title could also be renamed to [ Debug ] Layout Test http/tests/resourceLoadStatistics/prevalent-resource-with-user-interaction.html is flaky on macOS
Comment 3 Dawei Fenton (:realdawei) 2018-06-06 17:27:07 PDT
Created attachment 342099 [details]
Patch
Comment 4 WebKit Commit Bot 2018-06-06 17:57:41 PDT
Comment on attachment 342099 [details]
Patch

Clearing flags on attachment: 342099

Committed r232566: <https://trac.webkit.org/changeset/232566>
Comment 5 WebKit Commit Bot 2018-06-06 17:57:42 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-06-06 17:58:21 PDT
<rdar://problem/40875970>
Comment 7 Ryan Haddad 2018-06-07 09:53:46 PDT
Reopening since this only marked the test as flaky.