Bug 184048

Summary: Remove unused libsoup ResourceHandle implementation
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, cgarcia, commit-queue, ews, gns, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 184259    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
mcatanzaro: review+, commit-queue: commit-queue-
Patch for landing none

Description Alex Christensen 2018-03-27 10:45:07 PDT
Remove unused libsoup ResourceHandle implementation
Comment 1 Alex Christensen 2018-03-27 10:54:48 PDT
Created attachment 336595 [details]
Patch
Comment 2 Alex Christensen 2018-03-27 11:01:12 PDT
Created attachment 336596 [details]
Patch
Comment 3 Alex Christensen 2018-03-27 11:04:22 PDT
Created attachment 336597 [details]
Patch
Comment 4 Alex Christensen 2018-03-27 14:16:55 PDT
http://trac.webkit.org/r230008
Comment 5 Radar WebKit Bug Importer 2018-03-27 14:17:28 PDT
<rdar://problem/38927079>
Comment 6 Michael Catanzaro 2018-03-27 18:35:41 PDT
Looks like this code was less-unused than we might have hoped :)
Comment 7 Michael Catanzaro 2018-03-27 18:37:13 PDT
Reverted r230008 for reason:

Lots of HTTP test failures

Committed r230019: <https://trac.webkit.org/changeset/230019>
Comment 8 Michael Catanzaro 2018-03-27 18:38:40 PDT
Layout test timeouts in https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r230008%20(6011)/results.html. Looks like it's being used by the web inspector still, perhaps?
Comment 9 Alex Christensen 2018-04-03 11:00:58 PDT
Hmmm, we should stop using this code and remove it, then.
Comment 10 Michael Catanzaro 2018-04-03 11:42:26 PDT
I think you can try re-landing now.
Comment 11 Michael Catanzaro 2018-04-03 11:44:18 PDT
(In reply to Michael Catanzaro from comment #10)
> I think you can try re-landing now.

(after r230203)
Comment 12 WebKit Commit Bot 2018-04-03 12:46:18 PDT
Comment on attachment 336597 [details]
Patch

Rejecting attachment 336597 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 336597, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ing file Source/WebCore/platform/network/ResourceHandle.h
patching file Source/WebCore/platform/network/ResourceHandleInternal.h
patching file Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp
Hunk #1 FAILED at 63.
1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Michael Catanzaro']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/7195850
Comment 13 Carlos Garcia Campos 2018-04-03 23:10:57 PDT
Created attachment 337147 [details]
Patch for landing
Comment 14 WebKit Commit Bot 2018-04-03 23:55:19 PDT
Comment on attachment 337147 [details]
Patch for landing

Clearing flags on attachment: 337147

Committed r230251: <https://trac.webkit.org/changeset/230251>
Comment 15 WebKit Commit Bot 2018-04-03 23:55:21 PDT
All reviewed patches have been landed.  Closing bug.