Bug 184042

Summary: [GTK][WPE] Remove UpdateAtlas
Product: WebKit Reporter: Miguel Gomez <magomez>
Component: WebKitGTKAssignee: Miguel Gomez <magomez>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, commit-queue, zan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Miguel Gomez
Reported 2018-03-27 08:12:07 PDT
Stop using UpdateAtlas as a cache of buffers to draw cairo content, and allocate new buffers each time instead.
Attachments
Patch (52.97 KB, patch)
2018-03-27 08:22 PDT, Miguel Gomez 		no flags
DetailsFormatted DiffDiff
Patch (56.87 KB, patch)
2018-03-28 03:33 PDT, Miguel Gomez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Miguel Gomez
Comment 1 2018-03-27 08:22:00 PDT
Created attachment 336587 [details] Patch
Zan Dobersek
Comment 2 2018-03-27 12:38:52 PDT
Comment on attachment 336587 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336587&action=review > Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:984 > + updateInfo.surfaceOffset = {0, 0}; This can be more spacious: 'surfaceOffset = { 0, 0 }; Or better yet, it can be removed, perhaps in a separate patch. > Source/WebKit/WebProcess/WebPage/AcceleratedDrawingArea.h:78 > + void resetUpdateAtlasForTesting() override { }; Can we remove this as well? It's specific to coordgraphics.
Miguel Gomez
Comment 3 2018-03-28 03:33:38 PDT
Created attachment 336650 [details] Patch
WebKit Commit Bot
Comment 4 2018-03-28 05:30:15 PDT
Comment on attachment 336650 [details] Patch Clearing flags on attachment: 336650 Committed r230028: <https://trac.webkit.org/changeset/230028>
WebKit Commit Bot
Comment 5 2018-03-28 05:30:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.