| Summary: | [GStreamer] Enhance debugging in the BasePlayer | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Thibault Saunier <tsaunier> | ||||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, pnormand, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Thibault Saunier
2018-03-27 05:59:58 PDT
Created attachment 336574 [details]
Patch
Created attachment 336575 [details]
Patch
Broke WPE build:
/home/ews/igalia-wpe-ews/WebKit/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp: In lambda function:
/home/ews/igalia-wpe-ews/WebKit/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:384:39: error: ‘this’ was not captured for this lambda function
GST_DEBUG_OBJECT(pipeline(), "scheduling initializationDataEncountered event for %s with concatenated init datas size of %" G_GSIZE_FORMAT, eventKeySystemIdString.utf8().data(), initData.size());
^
/home/ews/igalia-wpe-ews/WebKit/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:384:39: error: cannot call member function ‘GstElement* WebCore::MediaPlayerPrivateGStreamerBase::pipeline() const’ without object
Created attachment 336589 [details]
Patch
Comment on attachment 336589 [details] Patch Clearing flags on attachment: 336589 Committed r229997: <https://trac.webkit.org/changeset/229997> All reviewed patches have been landed. Closing bug. |