Bug 184028

Summary: Web Inspector: Command-Shift-left/right arrow keys should not switch tabs when focused on color picker text fields
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, inspector-bugzilla-changes, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Animated GIF] Bug
none
Patch
none
Archive of layout-test-results from ews206 for win-future none

Nikita Vasilyev
Reported 2018-03-26 16:54:44 PDT
Created attachment 336554 [details] [Animated GIF] Bug Steps: 1. Open http://nv.github.io/webkit-inspector-bugs/styles-redesign/tests/color.html 2. Inspect <h1> 3. Click on a dark colored square before `#333` to open a color picker 4. Focus on R "51" text field 5. Press Command-Shift-Left or Command-Shift-Right Expected: Text get selected. Actual: Previous or next tab get selected.
Attachments
[Animated GIF] Bug (122.56 KB, image/gif)
2018-03-26 16:54 PDT, Nikita Vasilyev 		no flags
Details
Patch (1.84 KB, patch)
2018-03-26 16:58 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews206 for win-future (12.24 MB, application/zip)
2018-03-27 06:47 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Nikita Vasilyev
Comment 1 2018-03-26 16:58:10 PDT
Created attachment 336555 [details] Patch
EWS Watchlist
Comment 2 2018-03-27 06:47:32 PDT
Comment on attachment 336555 [details] Patch Attachment 336555 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7112291 New failing tests: http/tests/preload/download_resources.html
EWS Watchlist
Comment 3 2018-03-27 06:47:42 PDT
Created attachment 336579 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Nikita Vasilyev
Comment 4 2018-03-27 10:06:36 PDT
Comment on attachment 336555 [details] Patch Unrelated test regressions.
WebKit Commit Bot
Comment 5 2018-03-27 12:31:04 PDT
Comment on attachment 336555 [details] Patch Clearing flags on attachment: 336555 Committed r230001: <https://trac.webkit.org/changeset/230001>
WebKit Commit Bot
Comment 6 2018-03-27 12:31:05 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-03-27 12:34:08 PDT
<rdar://problem/38922748>
Note You need to log in before you can comment on or make changes to this bug.