Bug 183978

Summary: Adopt WK_PLATFORM_NAME in WebKit
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: mitz, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mitz: review+

Tim Horton
Reported 2018-03-24 01:44:14 PDT
Adopt WK_PLATFORM_NAME in WebKit
Attachments
Patch (18.51 KB, patch)
2018-03-24 01:57 PDT, Tim Horton 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2018-03-24 01:57:23 PDT
Created attachment 336467 [details] Patch
mitz
Comment 2 2018-03-24 09:19:59 PDT
Comment on attachment 336467 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336467&action=review > Source/WebKit/Configurations/WebKit.xcconfig:40 > +WK_WEAK_FRAMEWORK_ON_MAC = $(WK_WEAK_FRAMEWORK_ON_MAC_$(WK_COCOA_TOUCH)); Following the convention in other Apple projects this would be called WK_MACOS_WEAK_FRAMEWORK and go in Base.xcconfig.
Tim Horton
Comment 3 2018-03-24 21:32:57 PDT
https://trac.webkit.org/changeset/229958/webkit
Radar WebKit Bug Importer
Comment 4 2018-03-24 21:33:51 PDT
<rdar://problem/38834760>
Note You need to log in before you can comment on or make changes to this bug.