Bug 183966

Summary:

Use completion handlers for ResourceHandleClient::canAuthenticateAgainstProtectionSpaceAsync

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, dbates, ews-watchlist, japhet, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	cdumez: review+, cdumez: commit-queue-

Description Alex Christensen 2018-03-23 17:18:54 PDT

Use completion handlers for ResourceHandleClient::canAuthenticateAgainstProtectionSpaceAsync

Comment 1 Alex Christensen 2018-03-23 17:19:47 PDT

Created attachment 336446 [details]
Patch

Comment 2 Chris Dumez 2018-03-23 20:19:47 PDT

Comment on attachment 336446 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336446&action=review

r=me with fix

> Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:366
> +        auto completionHandler = [protectedThis = WTFMove(protectedThis)] (bool result) mutable {

You WTFMove() protectedThis here...

> Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:371
> +        if (!protectedThis->hasHandle())

...but use it here

Comment 3 Alex Christensen 2018-03-24 23:19:19 PDT

Fixed and landed in http://trac.webkit.org/r229959

Comment 4 Radar WebKit Bug Importer 2018-03-24 23:20:18 PDT

<rdar://problem/38835529>