Bug 183960

Summary: Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mitz, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Tim Horton
Reported 2018-03-23 16:25:31 PDT
Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name
Attachments
Patch (5.06 KB, patch)
2018-03-23 16:27 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (4.86 KB, patch)
2018-03-23 17:04 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-03-23 16:26:15 PDT
<rdar://problem/38812356>
Tim Horton
Comment 2 2018-03-23 16:27:50 PDT
Created attachment 336439 [details] Patch
mitz
Comment 3 2018-03-23 16:37:16 PDT
Comment on attachment 336439 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336439&action=review > Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig:68 > +DYLIB_INSTALL_NAME_BASE = $(DYLIB_INSTALL_NAME_BASE_PLATFORM); > +DYLIB_INSTALL_NAME_BASE_PLATFORM[sdk=iphone*] = $(SYSTEM_LIBRARY_DIR)/PrivateFrameworks; > +DYLIB_INSTALL_NAME_BASE_PLATFORM[sdk=macosx*] = $(DYLIB_INSTALL_NAME_BASE_PLATFORM_$(WK_USE_ALTERNATE_FRAMEWORKS_DIR)); > +DYLIB_INSTALL_NAME_BASE_PLATFORM_NO = $(NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR); > +DYLIB_INSTALL_NAME_BASE_PLATFORM_YES = $(DYLIB_INSTALL_NAME_BASE); This seems unnecessarily complicated and fragile (in case of an SDK that doesn’t match iphone* nor macosx*).
Tim Horton
Comment 4 2018-03-23 17:04:48 PDT
Created attachment 336445 [details] Patch
WebKit Commit Bot
Comment 5 2018-03-23 19:30:19 PDT
Comment on attachment 336445 [details] Patch Clearing flags on attachment: 336445 Committed r229942: <https://trac.webkit.org/changeset/229942>
WebKit Commit Bot
Comment 6 2018-03-23 19:30:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.