Bug 183951

Summary:

Web Inspector: Styles: don't show checkboxes for invalid properties

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, inspector-bugzilla-changes, mattbaker, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
[Animated GIF] With patch applied	none

Nikita Vasilyev

Reported 2018-03-23 14:36:47 PDT

Currently, unchecking an invalid property unexpectedly removes the property. Steps: 1. Open http://nv.github.io/webkit-inspector-bugs/styles-redesign/tests/invalid.html 2. Inspect <body> 3. Click on the checkbox for `color: blah;` or `invalid-name: blah;` Expected: Invalid property disables the same way as a valid property. Actual: Property gets removed. <rdar://problem/36797202> --- Fixing this would require non-trivial CSS parser changes on the backend. The backend has a heuristic to distinguish commented out properties, such as /* font-size: 11px */ from other comments, such as /* make this red */ The CSS parser isn't smart enough to distinguish an invalid CSS property, such as `color: blah`, from a comment that isn't a CSS property at all. As a workaround, I suggest to hide checkboxes for invalid properties. This is exactly what Chrome does.

Attachments
Patch (1.85 KB, patch) 2018-03-23 14:42 PDT, Nikita Vasilyev	no flags	Details Formatted Diff Diff
[Animated GIF] With patch applied (80.22 KB, image/gif) 2018-03-23 14:46 PDT, Nikita Vasilyev	no flags	Details
View All Add attachment proposed patch, testcase, etc.