Summary: | [Extra zoom mode] Adopt list view controller UI for select menus | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||||
Component: | Forms | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | aestes, bdakin, cdumez, commit-queue, thorton, webkit-bug-importer, wenson_hsieh | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Wenson Hsieh
2018-03-23 10:51:23 PDT
Created attachment 336390 [details]
Patch
Comment on attachment 336390 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336390&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4221 > + _selectMenuListViewController = adoptNS([[WKSelectMenuListViewController alloc] initWithDelegate:self]); > + [_selectMenuListViewController setDelegate:self]; Do you really need to call -initWithDelegate: and -setDelegate:? Comment on attachment 336390 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336390&action=review >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4221 >> + [_selectMenuListViewController setDelegate:self]; > > Do you really need to call -initWithDelegate: and -setDelegate:? Oops, we definitely don't. Good catch! Created attachment 336410 [details]
Patch for landing
Comment on attachment 336410 [details] Patch for landing Clearing flags on attachment: 336410 Committed r229916: <https://trac.webkit.org/changeset/229916> Created attachment 336428 [details]
Move new files to ios/forms/
Comment on attachment 336428 [details] Move new files to ios/forms/ Clearing flags on attachment: 336428 Committed r229928: <https://trac.webkit.org/changeset/229928> All reviewed patches have been landed. Closing bug. |