Bug 183944

Summary:

[Extra zoom mode] Adopt list view controller UI for select menus

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

Forms

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, bdakin, cdumez, commit-queue, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Move new files to ios/forms/	none

Wenson Hsieh

Reported 2018-03-23 10:51:23 PDT

<rdar://problem/38799062>

Attachments
Patch (25.10 KB, patch) 2018-03-23 10:59 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Patch for landing (25.04 KB, patch) 2018-03-23 12:49 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Move new files to ios/forms/ (16.79 KB, patch) 2018-03-23 14:57 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Wenson Hsieh

Comment 1 2018-03-23 10:59:18 PDT

Created attachment 336390 [details] Patch

Andy Estes

Comment 2 2018-03-23 11:23:21 PDT

Comment on attachment 336390 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336390&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4221 > + _selectMenuListViewController = adoptNS([[WKSelectMenuListViewController alloc] initWithDelegate:self]); > + [_selectMenuListViewController setDelegate:self]; Do you really need to call -initWithDelegate: and -setDelegate:?

Wenson Hsieh

Comment 3 2018-03-23 11:24:09 PDT

Comment on attachment 336390 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336390&action=review >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4221 >> + [_selectMenuListViewController setDelegate:self]; > > Do you really need to call -initWithDelegate: and -setDelegate:? Oops, we definitely don't. Good catch!

Wenson Hsieh

Comment 4 2018-03-23 12:49:30 PDT

Created attachment 336410 [details] Patch for landing

WebKit Commit Bot

Comment 5 2018-03-23 13:47:24 PDT

Comment on attachment 336410 [details] Patch for landing Clearing flags on attachment: 336410 Committed r229916: <https://trac.webkit.org/changeset/229916>

Wenson Hsieh

Comment 6 2018-03-23 14:57:11 PDT

Created attachment 336428 [details] Move new files to ios/forms/

WebKit Commit Bot

Comment 7 2018-03-23 15:35:44 PDT

Comment on attachment 336428 [details] Move new files to ios/forms/ Clearing flags on attachment: 336428 Committed r229928: <https://trac.webkit.org/changeset/229928>

WebKit Commit Bot

Comment 8 2018-03-23 15:35:46 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.