| Summary: | Add more support for pointer profiling. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | fpizlo, jfbastien, keith_miller, msaboff, rmorisset, saam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Mark Lam
2018-03-23 10:50:18 PDT
Created attachment 336392 [details]
proposed patch.
Comment on attachment 336392 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=336392&action=review r=me > Source/JavaScriptCore/assembler/AbstractMacroAssembler.h:898 > + assertIsTaggedWith(destination.executableAddress(), NearCallPtrTag); This won't be called when doing linking right? I'd expect the pointer to be zero at that point. Comment on attachment 336392 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=336392&action=review >> Source/JavaScriptCore/assembler/AbstractMacroAssembler.h:898 >> + assertIsTaggedWith(destination.executableAddress(), NearCallPtrTag); > > This won't be called when doing linking right? I'd expect the pointer to be zero at that point. This is a repatch function. Hence, the destination that we're patching to should never be null. Thanks for the review. Landed in r229911: <http://trac.webkit.org/r229911>. |